2024-01-31 08:54:53

by Kunwu Chan

Subject: [PATCH net-next] sctp: Simplify the allocation of slab caches

commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
introduces a new macro.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <[email protected]>
---
net/sctp/protocol.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 94c6dd53cd62..e849f368ed91 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1495,17 +1495,11 @@ static __init int sctp_init(void)

/* Allocate bind_bucket and chunk caches. */
status = -ENOBUFS;
- sctp_bucket_cachep = kmem_cache_create("sctp_bind_bucket",
- sizeof(struct sctp_bind_bucket),
- 0, SLAB_HWCACHE_ALIGN,
- NULL);
+ sctp_bucket_cachep = KMEM_CACHE(sctp_bind_bucket, SLAB_HWCACHE_ALIGN);
if (!sctp_bucket_cachep)
goto out;

- sctp_chunk_cachep = kmem_cache_create("sctp_chunk",
- sizeof(struct sctp_chunk),
- 0, SLAB_HWCACHE_ALIGN,
- NULL);
+ sctp_chunk_cachep = KMEM_CACHE(sctp_chunk, SLAB_HWCACHE_ALIGN);
if (!sctp_chunk_cachep)
goto err_chunk_cachep;

--
2.39.2

2024-01-31 15:47:40

by Jiri Pirko

Subject: Re: [PATCH net-next] sctp: Simplify the allocation of slab caches

Wed, Jan 31, 2024 at 09:45:49AM CET, [email protected] wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>

2024-02-01 01:52:19

by Xin Long

Subject: Re: [PATCH net-next] sctp: Simplify the allocation of slab caches

On Wed, Jan 31, 2024 at 3:46 AM Kunwu Chan <[email protected]> wrote:
>
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <[email protected]>
Acked-by: Xin Long <[email protected]>

2024-02-02 12:24:37

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] sctp: Simplify the allocation of slab caches

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Wed, 31 Jan 2024 16:45:49 +0800 you wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] sctp: Simplify the allocation of slab caches
https://git.kernel.org/netdev/net-next/c/fa33b35f86b8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html