2024-01-28 19:59:32

by Alexander Gordeev

Subject: [PATCH 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration

Callback arch_vtime_task_switch() is only defined when
CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is selected. Yet, the
function prototype forward declaration is present for
CONFIG_VIRT_CPU_ACCOUNTING_GEN variant. Remove it.

Signed-off-by: Alexander Gordeev <[email protected]>
---
include/linux/vtime.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/vtime.h b/include/linux/vtime.h
index 3684487d01e1..593466ceebed 100644
--- a/include/linux/vtime.h
+++ b/include/linux/vtime.h
@@ -18,7 +18,6 @@ extern void vtime_account_idle(struct task_struct *tsk);
#endif /* !CONFIG_VIRT_CPU_ACCOUNTING */

#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
-extern void arch_vtime_task_switch(struct task_struct *tsk);
extern void vtime_user_enter(struct task_struct *tsk);
extern void vtime_user_exit(struct task_struct *tsk);
extern void vtime_guest_enter(struct task_struct *tsk);
--
2.40.1

2024-02-06 22:07:06

by Frederic Weisbecker

Subject: Re: [PATCH 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration

Le Sun, Jan 28, 2024 at 08:58:50PM +0100, Alexander Gordeev a ?crit :
> Callback arch_vtime_task_switch() is only defined when
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is selected. Yet, the
> function prototype forward declaration is present for
> CONFIG_VIRT_CPU_ACCOUNTING_GEN variant. Remove it.
>
> Signed-off-by: Alexander Gordeev <[email protected]>

Reviewed-by: Frederic Weisbecker <[email protected]>