2022-11-26 10:31:03

by syzbot

[permalink] [raw]
Subject: [syzbot] WARNING in xfs_bmapi_convert_delalloc

Hello,

syzbot found the following issue on:

HEAD commit: a77d28d13789 Merge branch 'for-next/core' into for-kernelci
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
console output: https://syzkaller.appspot.com/x/log.txt?x=15cd6d45880000
kernel config: https://syzkaller.appspot.com/x/.config?x=c4c990190d758078
dashboard link: https://syzkaller.appspot.com/bug?extid=53b443b5c64221ee8bad
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/7c4b04ddbeb3/disk-a77d28d1.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3ecedb0cf6ca/vmlinux-a77d28d1.xz
kernel image: https://storage.googleapis.com/syzbot-assets/44c59c4393c7/Image-a77d28d1.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

------------[ cut here ]------------
WARNING: CPU: 0 PID: 3540 at fs/xfs/libxfs/xfs_bmap.c:4592 xfs_bmapi_convert_delalloc+0x67c/0x6b8 fs/xfs/libxfs/xfs_bmap.c:4592
Modules linked in:
CPU: 0 PID: 3540 Comm: kworker/u4:11 Not tainted 6.1.0-rc6-syzkaller-32651-ga77d28d13789 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/30/2022
Workqueue: writeback wb_workfn (flush-7:1)
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : xfs_bmapi_convert_delalloc+0x67c/0x6b8 fs/xfs/libxfs/xfs_bmap.c:4592
lr : xfs_bmapi_convert_delalloc+0x67c/0x6b8 fs/xfs/libxfs/xfs_bmap.c:4592
sp : ffff800015c334a0
x29: ffff800015c33580 x28: 0000000000000000 x27: 0000000000000000
x26: ffff800015c334f0 x25: ffffffffffffffff x24: ffff000119443000
x23: ffff0001198af440 x22: ffff800015c338f8 x21: ffff00011aa80000
x20: 0000000000000000 x19: ffff0001198af400 x18: 00000000000000ea
x17: ffff80000c0ed83c x16: 0000000000000000 x15: 0000000000000000
x14: 0000000000000000 x13: 0000000000000003 x12: ffff80000d601058
x11: ff80800008dd70f8 x10: 0000000000000000 x9 : ffff800008dd70f8
x8 : ffff0000f0c63480 x7 : ffff800008daa4cc x6 : 0000000000000000
x5 : 0000000000000000 x4 : 0000000000000000 x3 : ffff800008db0090
x2 : 0000000000000009 x1 : ffffffffffffffff x0 : ffffffffffffffff
Call trace:
xfs_bmapi_convert_delalloc+0x67c/0x6b8 fs/xfs/libxfs/xfs_bmap.c:4592
xfs_convert_blocks fs/xfs/xfs_aops.c:259 [inline]
xfs_map_blocks+0x4a8/0x6d8 fs/xfs/xfs_aops.c:380
iomap_writepage_map+0x190/0x8cc fs/iomap/buffered-io.c:1360
iomap_do_writepage+0x1c0/0x560 fs/iomap/buffered-io.c:1523
write_cache_pages+0x35c/0x8bc mm/page-writeback.c:2360
iomap_writepages+0x44/0xec fs/iomap/buffered-io.c:1540
xfs_vm_writepages+0x94/0xd4 fs/xfs/xfs_aops.c:500
do_writepages+0x144/0x27c mm/page-writeback.c:2469
__writeback_single_inode+0x64/0x2e4 fs/fs-writeback.c:1587
writeback_sb_inodes+0x3e4/0x85c fs/fs-writeback.c:1870
wb_writeback+0x198/0x328 fs/fs-writeback.c:2044
wb_do_writeback+0xc8/0x384 fs/fs-writeback.c:2187
wb_workfn+0x70/0x15c fs/fs-writeback.c:2227
process_one_work+0x2d8/0x504 kernel/workqueue.c:2289
worker_thread+0x340/0x610 kernel/workqueue.c:2436
kthread+0x12c/0x158 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:863
irq event stamp: 21709788
hardirqs last enabled at (21709787): [<ffff80000992ed1c>] get_random_u32+0x20c/0x294 drivers/char/random.c:510
hardirqs last disabled at (21709788): [<ffff80000c0a4074>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:405
softirqs last enabled at (21709658): [<ffff8000080102e4>] _stext+0x2e4/0x37c
softirqs last disabled at (21709557): [<ffff800008017c88>] ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:80
---[ end trace 0000000000000000 ]---
XFS (loop1): page discard on page fffffc00047d3f00, inode 0x62c, pos 13258752.
XFS (loop1): page discard on page fffffc00047d3f40, inode 0x62c, pos 13262848.
XFS (loop1): page discard on page fffffc00047d3f80, inode 0x62c, pos 13266944.
XFS (loop1): page discard on page fffffc00047d3fc0, inode 0x62c, pos 13271040.
XFS (loop1): page discard on page fffffc0004742800, inode 0x62c, pos 13275136.
XFS (loop1): page discard on page fffffc0004742840, inode 0x62c, pos 13279232.
XFS (loop1): page discard on page fffffc0004742880, inode 0x62c, pos 13283328.
XFS (loop1): page discard on page fffffc00047428c0, inode 0x62c, pos 13287424.
XFS (loop1): page discard on page fffffc0004742900, inode 0x62c, pos 13291520.
XFS (loop1): page discard on page fffffc0004742940, inode 0x62c, pos 13295616.


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.


2022-12-23 10:32:12

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [xfs?] WARNING in xfs_bmapi_convert_delalloc

syzbot has found a reproducer for the following issue on:

HEAD commit: a5541c0811a0 Merge branch 'for-next/core' into for-kernelci
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
console output: https://syzkaller.appspot.com/x/log.txt?x=13463cac480000
kernel config: https://syzkaller.appspot.com/x/.config?x=cbd4e584773e9397
dashboard link: https://syzkaller.appspot.com/bug?extid=53b443b5c64221ee8bad
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=169c10dd880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=133e74ff880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/4b7702208fb9/disk-a5541c08.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9ec0153ec051/vmlinux-a5541c08.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6f8725ad290a/Image-a5541c08.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/409d4f1e085d/mount_1.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

------------[ cut here ]------------
WARNING: CPU: 1 PID: 9 at fs/xfs/libxfs/xfs_bmap.c:4592 xfs_bmapi_convert_delalloc+0x624/0x63c fs/xfs/libxfs/xfs_bmap.c:4592
Modules linked in:
CPU: 1 PID: 9 Comm: kworker/u4:0 Not tainted 6.1.0-rc8-syzkaller-33330-ga5541c0811a0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Workqueue: writeback wb_workfn (flush-7:0)
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : xfs_bmapi_convert_delalloc+0x624/0x63c fs/xfs/libxfs/xfs_bmap.c:4592
lr : xfs_bmapi_convert_delalloc+0x624/0x63c fs/xfs/libxfs/xfs_bmap.c:4592
sp : ffff80000f2a3450
x29: ffff80000f2a3530 x28: 0000000000000000 x27: 0000000000000000
x26: ffff80000f2a34a0 x25: ffffffffffffffff x24: ffff0000cb842000
x23: ffff0000cadcba40 x22: ffff80000f2a3898 x21: ffff0000c79800e8
x20: 0000000000000000 x19: ffff0000cadcba00 x18: 00000000000003cc
x17: 0000000000000000 x16: ffff80000dbe6158 x15: ffff0000c02c8000
x14: 0000000000000000 x13: 00000000ffffffff x12: ffff0000c02c8000
x11: ff80800008dd39a8 x10: 0000000000000000 x9 : ffff800008dd39a8
x8 : ffff0000c02c8000 x7 : ffff800008dacf34 x6 : 0000000000000000
x5 : 0000000000000000 x4 : 0000000000000000 x3 : ffff800008db1b34
x2 : 0000000000000009 x1 : ffffffffffffffff x0 : ffffffffffffffff
Call trace:
xfs_bmapi_convert_delalloc+0x624/0x63c fs/xfs/libxfs/xfs_bmap.c:4592
xfs_convert_blocks fs/xfs/xfs_aops.c:259 [inline]
xfs_map_blocks+0x428/0x5b8 fs/xfs/xfs_aops.c:380
iomap_writepage_map+0x190/0x8cc fs/iomap/buffered-io.c:1360
iomap_do_writepage+0x1c0/0x560 fs/iomap/buffered-io.c:1523
write_cache_pages+0x35c/0x8bc mm/page-writeback.c:2360
iomap_writepages+0x44/0xec fs/iomap/buffered-io.c:1540
xfs_vm_writepages+0x94/0xd4 fs/xfs/xfs_aops.c:500
do_writepages+0x144/0x27c mm/page-writeback.c:2469
__writeback_single_inode+0x64/0x2e4 fs/fs-writeback.c:1587
writeback_sb_inodes+0x3e4/0x85c fs/fs-writeback.c:1878
__writeback_inodes_wb+0x78/0x1c0 fs/fs-writeback.c:1949
wb_writeback+0x1c8/0x328 fs/fs-writeback.c:2054
wb_check_background_flush fs/fs-writeback.c:2120 [inline]
wb_do_writeback+0x2cc/0x384 fs/fs-writeback.c:2208
wb_workfn+0x70/0x15c fs/fs-writeback.c:2235
process_one_work+0x2d8/0x504 kernel/workqueue.c:2289
worker_thread+0x340/0x610 kernel/workqueue.c:2436
kthread+0x12c/0x158 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:863
irq event stamp: 2056580
hardirqs last enabled at (2056579): [<ffff80000990e950>] get_random_u32+0x20c/0x294 drivers/char/random.c:510
hardirqs last disabled at (2056580): [<ffff80000c084084>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:405
softirqs last enabled at (2050472): [<ffff8000080102e4>] _stext+0x2e4/0x37c
softirqs last disabled at (2050435): [<ffff800008017c88>] ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:80
---[ end trace 0000000000000000 ]---
XFS (loop0): page discard on page 000000006c24b16e, inode 0x50b, pos 13840384.
XFS (loop0): page discard on page 00000000c29caf09, inode 0x50b, pos 13844480.

2024-02-07 06:02:19

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [xfs?] WARNING in xfs_bmapi_convert_delalloc

syzbot suspects this issue was fixed by commit:

commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <[email protected]>
Date: Wed Nov 1 17:43:10 2023 +0000

fs: Block writes to mounted block devices

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12b0ad7be80000
start commit: e8c127b05766 Merge tag 'net-6.6-rc6' of git://git.kernel.o..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
dashboard link: https://syzkaller.appspot.com/bug?extid=53b443b5c64221ee8bad
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a6f291680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=116bc355680000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: Block writes to mounted block devices

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

2024-02-07 21:18:13

by Dave Chinner

[permalink] [raw]
Subject: Re: [syzbot] [xfs?] WARNING in xfs_bmapi_convert_delalloc

On Tue, Feb 06, 2024 at 10:02:05PM -0800, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 6f861765464f43a71462d52026fbddfc858239a5
> Author: Jan Kara <[email protected]>
> Date: Wed Nov 1 17:43:10 2023 +0000
>
> fs: Block writes to mounted block devices
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12b0ad7be80000
> start commit: e8c127b05766 Merge tag 'net-6.6-rc6' of git://git.kernel.o..
> git tree: upstream
> kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
> dashboard link: https://syzkaller.appspot.com/bug?extid=53b443b5c64221ee8bad
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a6f291680000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=116bc355680000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: fs: Block writes to mounted block devices

For real? The test doesn't even open a mounted block device for
writes...

-Dave.
--
Dave Chinner
[email protected]

2024-02-07 22:33:40

by Jan Kara

[permalink] [raw]
Subject: Re: [syzbot] [xfs?] WARNING in xfs_bmapi_convert_delalloc

On Thu 08-02-24 08:17:24, Dave Chinner wrote:
> On Tue, Feb 06, 2024 at 10:02:05PM -0800, syzbot wrote:
> > syzbot suspects this issue was fixed by commit:
> >
> > commit 6f861765464f43a71462d52026fbddfc858239a5
> > Author: Jan Kara <[email protected]>
> > Date: Wed Nov 1 17:43:10 2023 +0000
> >
> > fs: Block writes to mounted block devices
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12b0ad7be80000
> > start commit: e8c127b05766 Merge tag 'net-6.6-rc6' of git://git.kernel.o..
> > git tree: upstream
> > kernel config: https://syzkaller.appspot.com/x/.config?x=11e478e28144788c
> > dashboard link: https://syzkaller.appspot.com/bug?extid=53b443b5c64221ee8bad
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a6f291680000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=116bc355680000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
> >
> > #syz fix: fs: Block writes to mounted block devices
>
> For real? The test doesn't even open a mounted block device for
> writes...

I was also confused by this. Somehow this commit makes the reproducer stop
working but I have no idea how that's possible.

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR