2024-02-01 17:14:37

by Andy Shevchenko

Subject: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

A few ad-hoc cleanups and one patch to make driver OF-independent.

Chagelog v2:
- renamed init to init_fn and typedef accordingly (Daniel)
- added tags (Daniel, Javier)

Andy Shevchenko (4):
backlight: hx8357: Make use of device properties
backlight: hx8357: Move OF table closer to its consumer
backlight: hx8357: Make use of dev_err_probe()
backlight: hx8357: Utilise temporary variable for struct device

drivers/video/backlight/hx8357.c | 57 +++++++++++++++-----------------
1 file changed, 27 insertions(+), 30 deletions(-)

--
2.43.0.rc1.1.gbec44491f096

2024-02-08 11:01:26

by Lee Jones

Subject: Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

On Thu, 01 Feb 2024 16:47:41 +0200, Andy Shevchenko wrote:
> A few ad-hoc cleanups and one patch to make driver OF-independent.
>
> Chagelog v2:
> - renamed init to init_fn and typedef accordingly (Daniel)
> - added tags (Daniel, Javier)
>
> Andy Shevchenko (4):
> backlight: hx8357: Make use of device properties
> backlight: hx8357: Move OF table closer to its consumer
> backlight: hx8357: Make use of dev_err_probe()
> backlight: hx8357: Utilise temporary variable for struct device
>
> [...]

Applied, thanks!

[1/4] backlight: hx8357: Make use of device properties
commit: d965a5ee7c95ce9414259181cbdccb1d2f1c1247
[2/4] backlight: hx8357: Move OF table closer to its consumer
commit: 3d226ecdfd83c0d89c1d4a430706e8228022685d
[3/4] backlight: hx8357: Make use of dev_err_probe()
commit: f0ed1589885ae933e2b2f9c63e16f5be3fb0324d
[4/4] backlight: hx8357: Utilise temporary variable for struct device
commit: 27a4701c92250ae0aecb2edea1109f89cf344ba1

--
Lee Jones [李琼斯]

2024-02-08 11:21:22

by Lee Jones

Subject: Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

On Thu, 01 Feb 2024, Andy Shevchenko wrote:

> A few ad-hoc cleanups and one patch to make driver OF-independent.
>
> Chagelog v2:
> - renamed init to init_fn and typedef accordingly (Daniel)
> - added tags (Daniel, Javier)
>
> Andy Shevchenko (4):
> backlight: hx8357: Make use of device properties
> backlight: hx8357: Move OF table closer to its consumer
> backlight: hx8357: Make use of dev_err_probe()
> backlight: hx8357: Utilise temporary variable for struct device
>
> drivers/video/backlight/hx8357.c | 57 +++++++++++++++-----------------
> 1 file changed, 27 insertions(+), 30 deletions(-)

Someone may wish to address this:

WARNING: DT compatible string "himax,hx8369" appears un-documented -- check ./Documentation/devicetree/bindings/
#58: FILE: drivers/video/backlight/hx8357.c:636:
+ .compatible = "himax,hx8369",

--
Lee Jones [李琼斯]

2024-02-08 17:29:00

by Andy Shevchenko

Subject: Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

On Thu, Feb 08, 2024 at 10:53:04AM +0000, Lee Jones wrote:
> On Thu, 01 Feb 2024, Andy Shevchenko wrote:

..

> Someone may wish to address this:
>
> WARNING: DT compatible string "himax,hx8369" appears un-documented -- check ./Documentation/devicetree/bindings/
> #58: FILE: drivers/video/backlight/hx8357.c:636:
> + .compatible = "himax,hx8369",

I can do it if and when have more time. But apparently it was before this
series, right?

--
With Best Regards,
Andy Shevchenko

2024-02-08 17:29:35

by Lee Jones

Subject: Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

On Thu, 08 Feb 2024, Andy Shevchenko wrote:

> On Thu, Feb 08, 2024 at 10:53:04AM +0000, Lee Jones wrote:
> > On Thu, 01 Feb 2024, Andy Shevchenko wrote:
>
> ...
>
> > Someone may wish to address this:
> >
> > WARNING: DT compatible string "himax,hx8369" appears un-documented -- check ./Documentation/devicetree/bindings/
> > #58: FILE: drivers/video/backlight/hx8357.c:636:
> > + .compatible = "himax,hx8369",
>
> I can do it if and when have more time. But apparently it was before this
> series, right?

I'm not sure it's ever been documented.

It doesn't affect your series in any way.

--
Lee Jones [李琼斯]