2024-02-13 16:27:57

by Andy Shevchenko

Subject: [PATCH v1 1/1] dyndbg: Replace kstrdup() + strchr() with kstrdup_and_replace()

Replace open coded functionalify of kstrdup_and_replace() with a call.

Signed-off-by: Andy Shevchenko <[email protected]>
---
lib/dynamic_debug.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6fba6423cc10..c78f335fa981 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -640,10 +640,9 @@ static int param_set_dyndbg_classnames(const char *instr, const struct kernel_pa
int cls_id, totct = 0;
bool wanted;

- cl_str = tmp = kstrdup(instr, GFP_KERNEL);
- p = strchr(cl_str, '\n');
- if (p)
- *p = '\0';
+ cl_str = tmp = kstrdup_and_replace(instr, '\n', '\0', GFP_KERNEL);
+ if (!tmp)
+ return -ENOMEM;

/* start with previously set state-bits, then modify */
curr_bits = old_bits = *dcp->bits;
--
2.43.0.rc1.1.gbec44491f096

2024-02-13 21:59:41

by Luis Chamberlain

Subject: Re: [PATCH v1 1/1] dyndbg: Replace kstrdup() + strchr() with kstrdup_and_replace()

On Tue, Feb 13, 2024 at 06:27:41PM +0200, Andy Shevchenko wrote:
> Replace open coded functionalify of kstrdup_and_replace() with a call.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Luis Chamberlain <[email protected]>

Luis