2024-02-14 15:57:02

by Krzysztof Kozlowski

Subject: [PATCH v2 2/2] dt-bindings: auxdisplay: hit,hd44780: use defines for GPIO flags

Improve example DTS readability by using known defines for GPIO flags.

Cc: Andy Shevchenko <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---

Changes in v2:
1. None
---
.../bindings/auxdisplay/hit,hd44780.yaml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml b/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml
index e26d61af9011..3ca0e9863d83 100644
--- a/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml
+++ b/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml
@@ -116,12 +116,12 @@ examples:
compatible = "hit,hd44780";
display-height-chars = <2>;
display-width-chars = <16>;
- data-gpios = <&pcf8574 4 0>,
- <&pcf8574 5 0>,
- <&pcf8574 6 0>,
- <&pcf8574 7 0>;
- enable-gpios = <&pcf8574 2 0>;
- rs-gpios = <&pcf8574 0 0>;
- rw-gpios = <&pcf8574 1 0>;
- backlight-gpios = <&pcf8574 3 0>;
+ data-gpios = <&pcf8574 4 GPIO_ACTIVE_HIGH>,
+ <&pcf8574 5 GPIO_ACTIVE_HIGH>,
+ <&pcf8574 6 GPIO_ACTIVE_HIGH>,
+ <&pcf8574 7 GPIO_ACTIVE_HIGH>;
+ enable-gpios = <&pcf8574 2 GPIO_ACTIVE_HIGH>;
+ rs-gpios = <&pcf8574 0 GPIO_ACTIVE_HIGH>;
+ rw-gpios = <&pcf8574 1 GPIO_ACTIVE_HIGH>;
+ backlight-gpios = <&pcf8574 3 GPIO_ACTIVE_HIGH>;
};
--
2.34.1

2024-02-14 16:04:22

by Geert Uytterhoeven

Subject: Re: [PATCH v2 2/2] dt-bindings: auxdisplay: hit,hd44780: use defines for GPIO flags

On Wed, Feb 14, 2024 at 4:54 PM Krzysztof Kozlowski
<[email protected]> wrote:
> Improve example DTS readability by using known defines for GPIO flags.
>
> Cc: Andy Shevchenko <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
>
> Changes in v2:
> 1. None

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-02-14 17:38:16

by Andy Shevchenko

Subject: Re: [PATCH v2 2/2] dt-bindings: auxdisplay: hit,hd44780: use defines for GPIO flags

On Wed, Feb 14, 2024 at 04:54:38PM +0100, Krzysztof Kozlowski wrote:
> Improve example DTS readability by using known defines for GPIO flags.

Applied, thanks!

--
With Best Regards,
Andy Shevchenko