2024-02-20 19:00:07

by Andy Shevchenko

Subject: [PATCH v1 1/1] device property: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <[email protected]>
---

This one heavily depends on the
https://lore.kernel.org/r/[email protected]

drivers/base/property.c | 11 ++++++-----
drivers/base/swnode.c | 13 ++++++++++++-
include/linux/fwnode.h | 4 ++--
include/linux/property.h | 1 +
4 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index afa1bf2b3c5a..7324a704a9a1 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -7,15 +7,16 @@
* Mika Westerberg <[email protected]>
*/

-#include <linux/acpi.h>
+#include <linux/device.h>
+#include <linux/err.h>
#include <linux/export.h>
-#include <linux/kernel.h>
+#include <linux/kconfig.h>
#include <linux/of.h>
-#include <linux/of_address.h>
-#include <linux/of_graph.h>
-#include <linux/of_irq.h>
#include <linux/property.h>
#include <linux/phy.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/types.h>

struct fwnode_handle *__dev_fwnode(struct device *dev)
{
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 36512fb75a20..eb6eb25b343b 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -6,10 +6,21 @@
* Author: Heikki Krogerus <[email protected]>
*/

+#include <linux/container_of.h>
#include <linux/device.h>
-#include <linux/kernel.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/idr.h>
+#include <linux/init.h>
+#include <linux/kobject.h>
+#include <linux/kstrtox.h>
+#include <linux/list.h>
#include <linux/property.h>
#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/string.h>
+#include <linux/sysfs.h>
+#include <linux/types.h>

#include "base.h"

diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 4228c45d5ccc..80f3cd91b471 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -9,10 +9,10 @@
#ifndef _LINUX_FWNODE_H_
#define _LINUX_FWNODE_H_

-#include <linux/types.h>
-#include <linux/list.h>
#include <linux/bits.h>
#include <linux/err.h>
+#include <linux/list.h>
+#include <linux/types.h>

enum dev_dma_attr {
DEV_DMA_NOT_SUPPORTED,
diff --git a/include/linux/property.h b/include/linux/property.h
index 1f0135e24d00..3a1045eb786c 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -11,6 +11,7 @@
#define _LINUX_PROPERTY_H_

#include <linux/args.h>
+#include <linux/array_size.h>
#include <linux/bits.h>
#include <linux/fwnode.h>
#include <linux/stddef.h>
--
2.43.0.rc1.1.gbec44491f096

2024-02-21 07:49:28

by Sakari Ailus

Subject: Re: [PATCH v1 1/1] device property: Don't use "proxy" headers

On Tue, Feb 20, 2024 at 06:18:50PM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Sakari Ailus <[email protected]>

--
Sakari Ailus

2024-02-23 15:30:47

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] device property: Don't use "proxy" headers

On Wed, Feb 21, 2024 at 07:48:54AM +0000, Sakari Ailus wrote:
> On Tue, Feb 20, 2024 at 06:18:50PM +0200, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
>
> Reviewed-by: Sakari Ailus <[email protected]>

Thank you, I will send it as a part of the series (v2).

--
With Best Regards,
Andy Shevchenko