2024-03-11 09:46:12

by Andy Shevchenko

Subject: [PATCH v1 1/1] MIPS: ralink: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use)
principle.

Fixes: 5804be061848 ("MIPS: ralink: Remove unused of_gpio.h")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Andy Shevchenko <[email protected]>
---
arch/mips/ralink/timer.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index 8b485cbe854e..54094f6e033e 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -6,10 +6,16 @@
* Copyright (C) 2013 John Crispin <[email protected]>
*/

-#include <linux/platform_device.h>
-#include <linux/interrupt.h>
-#include <linux/timer.h>
+#include <linux/bits.h>
#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_device.h>
+#include <linux/timer.h>
+#include <linux/types.h>

#include <asm/mach-ralink/ralink_regs.h>

--
2.43.0.rc1.1.gbec44491f096

2024-03-11 10:02:08

by Sergio Paracuellos

Subject: Re: [PATCH v1 1/1] MIPS: ralink: Don't use "proxy" headers

On Mon, Mar 11, 2024 at 10:46 AM Andy Shevchenko
<[email protected]> wrote:
>
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Fixes: 5804be061848 ("MIPS: ralink: Remove unused of_gpio.h")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> arch/mips/ralink/timer.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)

Acked-by: Sergio Paracuellos <[email protected]>

Thanks,
Sergio Paracuellos

2024-03-11 13:34:32

by Thomas Bogendoerfer

Subject: Re: [PATCH v1 1/1] MIPS: ralink: Don't use "proxy" headers

On Mon, Mar 11, 2024 at 11:45:58AM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Fixes: 5804be061848 ("MIPS: ralink: Remove unused of_gpio.h")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> arch/mips/ralink/timer.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
> index 8b485cbe854e..54094f6e033e 100644
> --- a/arch/mips/ralink/timer.c
> +++ b/arch/mips/ralink/timer.c
> @@ -6,10 +6,16 @@
> * Copyright (C) 2013 John Crispin <[email protected]>
> */
>
> -#include <linux/platform_device.h>
> -#include <linux/interrupt.h>
> -#include <linux/timer.h>
> +#include <linux/bits.h>
> #include <linux/clk.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +#include <linux/timer.h>
> +#include <linux/types.h>
>
> #include <asm/mach-ralink/ralink_regs.h>
>
> --
> 2.43.0.rc1.1.gbec44491f096

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]