2024-03-03 14:05:40

by R Sundar

[permalink] [raw]
Subject: [PATCH] Removed priv field description to prevent kernel doc warning

/include/linux/counter.h:400: warning: Excess struct member 'priv' description in 'counter_device'

Signed-off-by: R SUNDAR <[email protected]>
---
include/linux/counter.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/counter.h b/include/linux/counter.h
index 702e9108bbb4..b767b5c821f5 100644
--- a/include/linux/counter.h
+++ b/include/linux/counter.h
@@ -359,7 +359,6 @@ struct counter_ops {
* @num_counts: number of Counts specified in @counts
* @ext: optional array of Counter device extensions
* @num_ext: number of Counter device extensions specified in @ext
- * @priv: optional private data supplied by driver
* @dev: internal device structure
* @chrdev: internal character device structure
* @events_list: list of current watching Counter events
--
2.34.1



2024-03-03 14:13:53

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH] Removed priv field description to prevent kernel doc warning

On Sun, Mar 03, 2024 at 07:33:00PM +0530, R SUNDAR wrote:
> ./include/linux/counter.h:400: warning: Excess struct member 'priv' description in 'counter_device'
>
> Signed-off-by: R SUNDAR <[email protected]>
> ---
> include/linux/counter.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/counter.h b/include/linux/counter.h
> index 702e9108bbb4..b767b5c821f5 100644
> --- a/include/linux/counter.h
> +++ b/include/linux/counter.h
> @@ -359,7 +359,6 @@ struct counter_ops {
> * @num_counts: number of Counts specified in @counts
> * @ext: optional array of Counter device extensions
> * @num_ext: number of Counter device extensions specified in @ext
> - * @priv: optional private data supplied by driver
> * @dev: internal device structure
> * @chrdev: internal character device structure
> * @events_list: list of current watching Counter events
> --
> 2.34.1

Thank you for the patch, but it looks like this was already resolved by
an earlier patch[^1] and in counter-next as commit 0b3bbd8f9baf[^2]. It
should be picked up with the other Counter updates in the next merge
window for the Linux 6.9 cycle.

William Breathitt Gray

[^1]: https://lore.kernel.org/all/[email protected]/
[^2]: https://git.kernel.org/pub/scm/linux/kernel/git/wbg/counter.git/commit/?h=counter-next&id=0b3bbd8f9baf245ec77d86f6f5bc902105b4bfa9


Attachments:
(No filename) (1.40 kB)
signature.asc (235.00 B)
Download all attachments