2024-02-07 10:41:50

by Colin Ian King

Subject: [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data

The pointer data is being assigned a value that is not being
read afterwards, it is being re-assigned later inside a do-while
loop. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/usb/serial/keyspan.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 93b17e0e05a3..0a783985197c 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -921,7 +921,6 @@ static void usa28_indat_callback(struct urb *urb)

port = urb->context;
p_priv = usb_get_serial_port_data(port);
- data = urb->transfer_buffer;

if (urb != p_priv->in_urbs[p_priv->in_flip])
return;
--
2.39.2

2024-03-04 14:18:56

by Johan Hovold

Subject: Re: [PATCH][next] USB: serial: keyspan: Remove redundant assignment to pointer data

On Wed, Feb 07, 2024 at 10:41:28AM +0000, Colin Ian King wrote:
> The pointer data is being assigned a value that is not being
> read afterwards, it is being re-assigned later inside a do-while
> loop. The assignment is redundant and can be removed.
>
> Cleans up clang scan warning:
> drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks.

Johan