2024-03-06 04:19:14

by Hsin-Yu.Chen

[permalink] [raw]
Subject: [PATCH] i2c: remove redundant condition

I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need for an additional condition to obtain the value

Signed-off-by: Hsin-Yu.Chen <[email protected]>
---
include/linux/i2c.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)

static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
{
- return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+ return (msg->addr << 1) | (msg->flags & I2C_M_RD);
}

u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
--
2.38.1



2024-03-07 08:37:48

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: remove redundant condition

On Wed, Mar 06, 2024 at 12:19:00PM +0800, Hsin-Yu.Chen wrote:
> I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
> no need for an additional condition to obtain the value
>
> Signed-off-by: Hsin-Yu.Chen <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (280.00 B)
signature.asc (849.00 B)
Download all attachments