From: Len Brown <[email protected]>
Some words are alarming in routine kernel messages.
"timeout" is one of them, so avoid using it.
Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")
Suggested-by: Keith Busch <[email protected]>
Signed-off-by: Len Brown <[email protected]>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0a96362912ce..2601dc1c4f42 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3206,7 +3206,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
if (ctrl->shutdown_timeout != shutdown_timeout)
dev_info(ctrl->device,
- "Shutdown timeout set to %u seconds\n",
+ "D3 entry latency set to %u seconds\n",
ctrl->shutdown_timeout);
} else
ctrl->shutdown_timeout = shutdown_timeout;
--
2.40.1
On Thu, Mar 07, 2024 at 02:17:34PM -0500, Len Brown wrote:
> From: Len Brown <[email protected]>
>
> Some words are alarming in routine kernel messages.
> "timeout" is one of them, so avoid using it.
>
> Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")
>
> Suggested-by: Keith Busch <[email protected]>
> Signed-off-by: Len Brown <[email protected]>
Our messages must have crossed:
https://lore.kernel.org/linux-nvme/[email protected]/T/#u
I haven't been receiving random messages from the list lately either. Or
maybe I cc'ed the wrong email.
Anyway, we just sent the nvme-6.9 pull request today, so I'll wait a few
more days before starting the next batch.
On 3/7/24 11:17, Len Brown wrote:
> From: Len Brown <[email protected]>
>
> Some words are alarming in routine kernel messages.
> "timeout" is one of them, so avoid using it.
>
> Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")
>
> Suggested-by: Keith Busch <[email protected]>
> Signed-off-by: Len Brown <[email protected]>
> ---
> drivers/nvme/host/core.c | 2 +-
>
not sure which one will get in, hence ...
Reviewed-by: Chaitanya Kulkarni <[email protected]>
-ck
Whatever is taken...
Reviewed-by: Sagi Grimberg <[email protected]>