This series adds a driver for a 7-segment LED display.
I think I've addressed all of Andy's feedback in this round. I haven't
heard from the ARM maintainers on any of the previous rounds. I can
submit the dts change separately if required, I've mostly been including
it so there is an in-tree user of the driver I'm adding.
Chris Packham (3):
auxdisplay: Add 7-segment LED display driver
dt-bindings: auxdisplay: Add bindings for generic 7-segment LED
ARM: dts: marvell: Add 7-segment LED display on x530
.../bindings/auxdisplay/gpio-7-segment.yaml | 55 +++++++++
.../boot/dts/marvell/armada-385-atl-x530.dts | 13 +-
drivers/auxdisplay/Kconfig | 11 ++
drivers/auxdisplay/Makefile | 1 +
drivers/auxdisplay/seg-led-gpio.c | 112 ++++++++++++++++++
5 files changed, 191 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml
create mode 100644 drivers/auxdisplay/seg-led-gpio.c
--
2.43.2
The Allied Telesis x530 products have a 7-segment LED display which is
used for node identification when the devices are stacked. Represent
this as a gpio-7-segment device.
Signed-off-by: Chris Packham <[email protected]>
---
Notes:
Changes in v6:
- None
Changes in v5:
- group GPIO specifiers
Changes in v4:
- Use correct compatible name in commit message
Changes in v3:
- Use compatible = "gpio-7-segment" as suggested by Rob
Changes in v2:
- Use compatible = "generic-gpio-7seg" to keep checkpatch.pl happy
arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
index 5a9ab8410b7b..2fb7304039be 100644
--- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
+++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
@@ -43,6 +43,17 @@ uart0: serial@12000 {
};
};
};
+
+ led-7seg {
+ compatible = "gpio-7-segment";
+ segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 1 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 2 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 3 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 4 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 5 GPIO_ACTIVE_LOW>,
+ <&led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
+ };
};
&pciec {
@@ -149,7 +160,7 @@ i2c@3 {
#size-cells = <0>;
reg = <3>;
- gpio@20 {
+ led_7seg_gpio: gpio@20 {
compatible = "nxp,pca9554";
gpio-controller;
#gpio-cells = <2>;
--
2.43.2
On Fri, Mar 08, 2024 at 08:50:50AM +1300, Chris Packham wrote:
> This series adds a driver for a 7-segment LED display.
You were too fast to miss some tags, but they are related to the last patch
which according to Arnd's suggestion I'm not going to take right now.
So, the first two on their way, thanks!
--
With Best Regards,
Andy Shevchenko