2024-03-15 13:25:05

by Rajendra Nayak

Subject: [PATCH] arm64: dts: qcom: Fix the compatible for cluster idle states

The compatible's for the cluster/domain idle states of x1e80100
are wrong, fix it.

Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
Signed-off-by: Rajendra Nayak <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 8e517f76189e..6b40082bac68 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -284,7 +284,7 @@ CLUSTER_C4: cpu-sleep-0 {

domain-idle-states {
CLUSTER_CL4: cluster-sleep-0 {
- compatible = "arm,idle-state";
+ compatible = "domain-idle-state";
idle-state-name = "l2-ret";
arm,psci-suspend-param = <0x01000044>;
entry-latency-us = <350>;
@@ -293,7 +293,7 @@ CLUSTER_CL4: cluster-sleep-0 {
};

CLUSTER_CL5: cluster-sleep-1 {
- compatible = "arm,idle-state";
+ compatible = "domain-idle-state";
idle-state-name = "ret-pll-off";
arm,psci-suspend-param = <0x01000054>;
entry-latency-us = <2200>;
--
2.34.1

2024-03-15 17:19:42

by Abel Vesa

Subject: Re: [PATCH] arm64: dts: qcom: Fix the compatible for cluster idle states

On 24-03-15 18:54:23, Rajendra Nayak wrote:
> The compatible's for the cluster/domain idle states of x1e80100
> are wrong, fix it.
>
> Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
> Signed-off-by: Rajendra Nayak <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 8e517f76189e..6b40082bac68 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -284,7 +284,7 @@ CLUSTER_C4: cpu-sleep-0 {
>
> domain-idle-states {
> CLUSTER_CL4: cluster-sleep-0 {
> - compatible = "arm,idle-state";
> + compatible = "domain-idle-state";
> idle-state-name = "l2-ret";
> arm,psci-suspend-param = <0x01000044>;
> entry-latency-us = <350>;
> @@ -293,7 +293,7 @@ CLUSTER_CL4: cluster-sleep-0 {
> };
>
> CLUSTER_CL5: cluster-sleep-1 {
> - compatible = "arm,idle-state";
> + compatible = "domain-idle-state";
> idle-state-name = "ret-pll-off";
> arm,psci-suspend-param = <0x01000054>;
> entry-latency-us = <2200>;
> --
> 2.34.1
>

2024-03-15 19:41:11

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: Fix the compatible for cluster idle states

On 15.03.2024 14:24, Rajendra Nayak wrote:
> The compatible's for the cluster/domain idle states of x1e80100
> are wrong, fix it.
>
> Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
> Signed-off-by: Rajendra Nayak <[email protected]>
> ---

The title should mention "qcom: x1e80100:"

For the contents:

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad