2024-03-18 18:51:48

by Ayush Tiwari

Subject: [PATCH v2] staging: rtl8712: Fix line length exceeding 100 columns

Split the argument list of the kthread_run function call across two
lines to address the checkpatch warning "line length exceeds 100
columns".

Signed-off-by: Ayush Tiwari <[email protected]>

---
change in v2: Fixed the alignment to address checkpatch.pl warning
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index e77fcfc465ba..1b11f8b04e13 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -222,7 +222,7 @@ struct net_device *r8712_init_netdev(void)
static u32 start_drv_threads(struct _adapter *padapter)
{
padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s",
- padapter->pnetdev->name);
+ padapter->pnetdev->name);
if (IS_ERR(padapter->cmd_thread))
return _FAIL;
return _SUCCESS;
--
2.40.1

2024-03-19 05:58:39

by Dan Carpenter

Subject: Re: [PATCH v2] staging: rtl8712: Fix line length exceeding 100 columns

On Tue, Mar 19, 2024 at 12:21:34AM +0530, Ayush Tiwari wrote:
> Split the argument list of the kthread_run function call across two
> lines to address the checkpatch warning "line length exceeds 100
> columns".
>
> Signed-off-by: Ayush Tiwari <[email protected]>
>
> ---
> change in v2: Fixed the alignment to address checkpatch.pl warning

You've created this patch to be applied on top of the v1 patch that we
are not going to apply. You need to restart based on a clean repo.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter