2024-03-31 09:17:57

by Krzysztof Kozlowski

Subject: [PATCH v2 1/3] usb: phy: fsl-usb: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes in v2:
1. None
---
drivers/usb/phy/phy-fsl-usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
index 79617bb0a70e..1ebbf189a535 100644
--- a/drivers/usb/phy/phy-fsl-usb.c
+++ b/drivers/usb/phy/phy-fsl-usb.c
@@ -1005,7 +1005,6 @@ struct platform_driver fsl_otg_driver = {
.remove_new = fsl_otg_remove,
.driver = {
.name = driver_name,
- .owner = THIS_MODULE,
},
};

--
2.34.1

2024-03-31 09:18:10

by Krzysztof Kozlowski

Subject: [PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

Core in typec_altmode_register_driver() already sets the .owner, so
driver does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes in v2:
1. None
---
drivers/usb/typec/altmodes/nvidia.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
index c36769736405..fe70b36f078f 100644
--- a/drivers/usb/typec/altmodes/nvidia.c
+++ b/drivers/usb/typec/altmodes/nvidia.c
@@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
.remove = nvidia_altmode_remove,
.driver = {
.name = "typec_nvidia",
- .owner = THIS_MODULE,
},
};
module_typec_altmode_driver(nvidia_altmode_driver);
--
2.34.1

2024-03-31 09:18:24

by Krzysztof Kozlowski

Subject: [PATCH v2 3/3] usb: typec: displayport: drop driver owner assignment

Core in typec_altmode_register_driver() already sets the .owner, so
driver does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes in v2:
1. New patch
---
drivers/usb/typec/altmodes/displayport.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index 038dc51f429d..596cd4806018 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -802,7 +802,6 @@ static struct typec_altmode_driver dp_altmode_driver = {
.remove = dp_altmode_remove,
.driver = {
.name = "typec_displayport",
- .owner = THIS_MODULE,
.dev_groups = displayport_groups,
},
};
--
2.34.1

2024-04-03 11:28:11

by Heikki Krogerus

Subject: Re: [PATCH v2 3/3] usb: typec: displayport: drop driver owner assignment

On Sun, Mar 31, 2024 at 11:17:37AM +0200, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
>
> Changes in v2:
> 1. New patch
> ---
> drivers/usb/typec/altmodes/displayport.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index 038dc51f429d..596cd4806018 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -802,7 +802,6 @@ static struct typec_altmode_driver dp_altmode_driver = {
> .remove = dp_altmode_remove,
> .driver = {
> .name = "typec_displayport",
> - .owner = THIS_MODULE,
> .dev_groups = displayport_groups,
> },
> };
> --
> 2.34.1

--
heikki

2024-04-03 11:42:15

by Heikki Krogerus

Subject: Re: [PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

On Sun, Mar 31, 2024 at 11:17:36AM +0200, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
>
> Changes in v2:
> 1. None
> ---
> drivers/usb/typec/altmodes/nvidia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
> index c36769736405..fe70b36f078f 100644
> --- a/drivers/usb/typec/altmodes/nvidia.c
> +++ b/drivers/usb/typec/altmodes/nvidia.c
> @@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
> .remove = nvidia_altmode_remove,
> .driver = {
> .name = "typec_nvidia",
> - .owner = THIS_MODULE,
> },
> };
> module_typec_altmode_driver(nvidia_altmode_driver);
> --
> 2.34.1

--
heikki