2024-03-05 21:14:54

by Uri Arev

[permalink] [raw]

Subject: [PATCH] staging: axis-fifo: Fix indentation

---

From: Uri Arev <[email protected]>

Warning reported by checkpatch.pl script:

CHECK: Alignment should match open parenthesis

Signed-off-by: Uri Arev <[email protected]>
---
drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 727b956aa231..ab758a527261 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
- read_timeout);
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ read_timeout);

if (ret <= 0) {
if (ret == 0) {
@@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
*/
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible_timeout(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
- >= words_to_write,
- write_timeout);
+ ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+ >= words_to_write,
+ write_timeout);

if (ret <= 0) {
if (ret == 0) {
--
2.42.0

2024-03-31 19:05:54

by Uri Arev

[permalink] [raw]

Subject: Re: [PATCH] staging: axis-fifo: Fix indentation

---

Hey, just pinging to check if you saw my patch.

Uri Arev

2024-04-01 12:26:41

by Bagas Sanjaya

[permalink] [raw]

Subject: Re: [PATCH] staging: axis-fifo: Fix indentation

---

On Tue, Mar 05, 2024 at 11:14:01PM +0200, [email protected] wrote:
> From: Uri Arev <[email protected]>
>
> Warning reported by checkpatch.pl script:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Uri Arev <[email protected]>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 727b956aa231..ab758a527261 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - read_timeout);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + read_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {
> @@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> */
> mutex_lock(&fifo->write_lock);
> ret = wait_event_interruptible_timeout(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> - >= words_to_write,
> - write_timeout);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> + >= words_to_write,
> + write_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <[email protected]>

--
An old man doll... just what I always wanted! - Clara

---

Attachments:

(No filename) (1.60 kB)
signature.asc (235.00 B)
Download all attachments

2024-04-01 15:36:39

by Uri Arev

[permalink] [raw]

Subject: Re: [PATCH] staging: axis-fifo: Fix indentation

---

On Mon, Apr 01, 2024 at 07:26:26PM +0700, Bagas Sanjaya wrote:
> LGTM, thanks!
>
> Reviewed-by: Bagas Sanjaya <[email protected]>
Thank you so much for the review! Have a great day

Uri Arev