2024-03-27 17:50:43

by Krzysztof Kozlowski

Subject: [PATCH 1/2] usb: phy: fsl-usb: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/phy/phy-fsl-usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
index 79617bb0a70e..1ebbf189a535 100644
--- a/drivers/usb/phy/phy-fsl-usb.c
+++ b/drivers/usb/phy/phy-fsl-usb.c
@@ -1005,7 +1005,6 @@ struct platform_driver fsl_otg_driver = {
.remove_new = fsl_otg_remove,
.driver = {
.name = driver_name,
- .owner = THIS_MODULE,
},
};

--
2.34.1

2024-03-27 17:51:08

by Krzysztof Kozlowski

Subject: [PATCH 2/2] usb: typec: nvidia: drop driver owner assignment

Core in typec_altmode_register_driver() already sets the .owner, so
driver does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/typec/altmodes/nvidia.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
index c36769736405..fe70b36f078f 100644
--- a/drivers/usb/typec/altmodes/nvidia.c
+++ b/drivers/usb/typec/altmodes/nvidia.c
@@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
.remove = nvidia_altmode_remove,
.driver = {
.name = "typec_nvidia",
- .owner = THIS_MODULE,
},
};
module_typec_altmode_driver(nvidia_altmode_driver);
--
2.34.1

2024-04-02 16:17:26

by Heikki Krogerus

Subject: Re: [PATCH 1/2] usb: phy: fsl-usb: drop driver owner assignment

On Wed, Mar 27, 2024 at 06:46:08PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/phy/phy-fsl-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c
> index 79617bb0a70e..1ebbf189a535 100644
> --- a/drivers/usb/phy/phy-fsl-usb.c
> +++ b/drivers/usb/phy/phy-fsl-usb.c
> @@ -1005,7 +1005,6 @@ struct platform_driver fsl_otg_driver = {
> .remove_new = fsl_otg_remove,
> .driver = {
> .name = driver_name,
> - .owner = THIS_MODULE,
> },
> };
>
> --
> 2.34.1

--
heikki

2024-04-02 16:17:28

by Heikki Krogerus

Subject: Re: [PATCH 2/2] usb: typec: nvidia: drop driver owner assignment

On Wed, Mar 27, 2024 at 06:46:09PM +0100, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/altmodes/nvidia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/nvidia.c b/drivers/usb/typec/altmodes/nvidia.c
> index c36769736405..fe70b36f078f 100644
> --- a/drivers/usb/typec/altmodes/nvidia.c
> +++ b/drivers/usb/typec/altmodes/nvidia.c
> @@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
> .remove = nvidia_altmode_remove,
> .driver = {
> .name = "typec_nvidia",
> - .owner = THIS_MODULE,
> },
> };
> module_typec_altmode_driver(nvidia_altmode_driver);
> --
> 2.34.1

--
heikki