2024-03-28 22:09:05

by Krzysztof Kozlowski

Subject: [PATCH 00/52] USB: store owner from modules with usb_serial_register_drivers()

Merging
=======
All further patches depend on the first patch.

Description
===========
This is going to be a bit of a patch-bomb, but with trivial patches, so
I think it is still acceptable. If it is too much, apologies and I will
solve it.

Modules registering driver with usb_serial_register_drivers() might
forget to set .owner field.

Solve the problem by moving this task away from the drivers to the core
amba bus code, just like we did for platform_driver in commit
9447057eaff8 ("platform_device: use a macro instead of
platform_driver_register").

Best regards,
Krzysztof

---
Krzysztof Kozlowski (52):
USB: serial: store owner from modules with usb_serial_register_drivers()
USB: serial: aircable: drop driver owner initialization
USB: serial: ark3116: drop driver owner initialization
USB: serial: belkin_sa: drop driver owner initialization
USB: serial: ch341: drop driver owner initialization
USB: serial: cp210x: drop driver owner initialization
USB: serial: cyberjack: drop driver owner initialization
USB: serial: cypress_m8: drop driver owner initialization
USB: serial: digi_acceleport: drop driver owner initialization
USB: serial: empeg: drop driver owner initialization
USB: serial: f81232: drop driver owner initialization
USB: serial: ftdi_sio: drop driver owner initialization
USB: serial: garmin_gps: drop driver owner initialization
USB: serial: generic: drop driver owner initialization
USB: serial: io_edgeport: drop driver owner initialization
USB: serial: io_ti: drop driver owner initialization
USB: serial: ipaq: drop driver owner initialization
USB: serial: ipw: drop driver owner initialization
USB: serial: ir-usb: drop driver owner initialization
USB: serial: iuu: drop driver owner initialization
USB: serial: keyspan: drop driver owner initialization
USB: serial: keyspan_pda: drop driver owner initialization
USB: serial: kl5kusb105: drop driver owner initialization
USB: serial: kobil_sct: drop driver owner initialization
USB: serial: mct_u232: drop driver owner initialization
USB: serial: metro_usb: drop driver owner initialization
USB: serial: mos7720: drop driver owner initialization
USB: serial: mos7840: drop driver owner initialization
USB: serial: mxuport: drop driver owner initialization
USB: serial: navman: drop driver owner initialization
USB: serial: omninet: drop driver owner initialization
USB: serial: opticon: drop driver owner initialization
USB: serial: option: drop driver owner initialization
USB: serial: oti6858: drop driver owner initialization
USB: serial: pl2303: drop driver owner initialization
USB: serial: qcaux: drop driver owner initialization
USB: serial: qcserial: drop driver owner initialization
USB: serial: quatech2: drop driver owner initialization
USB: serial: safe_serial: drop driver owner initialization
USB: serial: sierra: drop driver owner initialization
USB: serial: spcp8x5: drop driver owner initialization
USB: serial: ssu100: drop driver owner initialization
USB: serial: symbol: drop driver owner initialization
USB: serial: ti_usb_3410_5052: drop driver owner initialization
USB: serial: upd78f0730: drop driver owner initialization
USB: serial: simple: drop driver owner initialization
USB: serial: debug: drop driver owner initialization
USB: serial: visor: drop driver owner initialization
USB: serial: whiteheat: drop driver owner initialization
USB: serial: wishbone: drop driver owner initialization
USB: serial: xr: drop driver owner initialization
USB: serial: xsens_mt: drop driver owner initialization

drivers/usb/serial/aircable.c | 1 -
drivers/usb/serial/ark3116.c | 1 -
drivers/usb/serial/belkin_sa.c | 1 -
drivers/usb/serial/ch341.c | 1 -
drivers/usb/serial/cp210x.c | 1 -
drivers/usb/serial/cyberjack.c | 1 -
drivers/usb/serial/cypress_m8.c | 3 ---
drivers/usb/serial/digi_acceleport.c | 2 --
drivers/usb/serial/empeg.c | 1 -
drivers/usb/serial/f81232.c | 2 --
drivers/usb/serial/ftdi_sio.c | 1 -
drivers/usb/serial/garmin_gps.c | 1 -
drivers/usb/serial/generic.c | 1 -
drivers/usb/serial/io_edgeport.c | 4 ----
drivers/usb/serial/io_ti.c | 2 --
drivers/usb/serial/ipaq.c | 1 -
drivers/usb/serial/ipw.c | 1 -
drivers/usb/serial/ir-usb.c | 1 -
drivers/usb/serial/iuu_phoenix.c | 1 -
drivers/usb/serial/keyspan.c | 4 ----
drivers/usb/serial/keyspan_pda.c | 2 --
drivers/usb/serial/kl5kusb105.c | 1 -
drivers/usb/serial/kobil_sct.c | 1 -
drivers/usb/serial/mct_u232.c | 1 -
drivers/usb/serial/metro-usb.c | 1 -
drivers/usb/serial/mos7720.c | 1 -
drivers/usb/serial/mos7840.c | 1 -
drivers/usb/serial/mxuport.c | 1 -
drivers/usb/serial/navman.c | 1 -
drivers/usb/serial/omninet.c | 1 -
drivers/usb/serial/opticon.c | 1 -
drivers/usb/serial/option.c | 1 -
drivers/usb/serial/oti6858.c | 1 -
drivers/usb/serial/pl2303.c | 1 -
drivers/usb/serial/qcaux.c | 1 -
drivers/usb/serial/qcserial.c | 1 -
drivers/usb/serial/quatech2.c | 1 -
drivers/usb/serial/safe_serial.c | 1 -
drivers/usb/serial/sierra.c | 1 -
drivers/usb/serial/spcp8x5.c | 1 -
drivers/usb/serial/ssu100.c | 1 -
drivers/usb/serial/symbolserial.c | 1 -
drivers/usb/serial/ti_usb_3410_5052.c | 2 --
drivers/usb/serial/upd78f0730.c | 1 -
drivers/usb/serial/usb-serial-simple.c | 1 -
drivers/usb/serial/usb-serial.c | 12 +++++++-----
drivers/usb/serial/usb_debug.c | 2 --
drivers/usb/serial/visor.c | 3 ---
drivers/usb/serial/whiteheat.c | 2 --
drivers/usb/serial/wishbone-serial.c | 1 -
drivers/usb/serial/xr_serial.c | 1 -
drivers/usb/serial/xsens_mt.c | 1 -
include/linux/usb/serial.h | 7 +++++--
53 files changed, 12 insertions(+), 75 deletions(-)
---
base-commit: 7fdcff3312e16ba8d1419f8a18f465c5cc235ecf
change-id: 20240328-module-owner-usb-serial-8a067f622b70

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2024-03-28 22:09:12

by Krzysztof Kozlowski

Subject: [PATCH 08/52] USB: serial: cypress_m8: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/cypress_m8.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 1e0c028c5ec9..ce9134bb30f3 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -139,7 +139,6 @@ static void cypress_write_int_callback(struct urb *urb);

static struct usb_serial_driver cypress_earthmate_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "earthmate",
},
.description = "DeLorme Earthmate USB",
@@ -166,7 +165,6 @@ static struct usb_serial_driver cypress_earthmate_device = {

static struct usb_serial_driver cypress_hidcom_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "cyphidcom",
},
.description = "HID->COM RS232 Adapter",
@@ -192,7 +190,6 @@ static struct usb_serial_driver cypress_hidcom_device = {

static struct usb_serial_driver cypress_ca42v2_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "nokiaca42v2",
},
.description = "Nokia CA-42 V2 Adapter",

--
2.34.1

2024-03-28 22:09:27

by Krzysztof Kozlowski

Subject: [PATCH 09/52] USB: serial: digi_acceleport: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/digi_acceleport.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index d1dea3850576..a06485965412 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -262,7 +262,6 @@ MODULE_DEVICE_TABLE(usb, id_table_combined);

static struct usb_serial_driver digi_acceleport_2_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "digi_2",
},
.description = "Digi 2 port USB adapter",
@@ -293,7 +292,6 @@ static struct usb_serial_driver digi_acceleport_2_device = {

static struct usb_serial_driver digi_acceleport_4_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "digi_4",
},
.description = "Digi 4 port USB adapter",

--
2.34.1

2024-03-28 22:09:43

by Krzysztof Kozlowski

Subject: [PATCH 02/52] USB: serial: aircable: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/aircable.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
index a1df686c3066..aa517242d060 100644
--- a/drivers/usb/serial/aircable.c
+++ b/drivers/usb/serial/aircable.c
@@ -138,7 +138,6 @@ static void aircable_process_read_urb(struct urb *urb)

static struct usb_serial_driver aircable_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "aircable",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:10:09

by Krzysztof Kozlowski

Subject: [PATCH 11/52] USB: serial: f81232: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/f81232.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 5f7a46bcace6..530b77fc2f78 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -967,7 +967,6 @@ static int f81232_resume(struct usb_serial *serial)

static struct usb_serial_driver f81232_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "f81232",
},
.id_table = f81232_id_table,
@@ -994,7 +993,6 @@ static struct usb_serial_driver f81232_device = {

static struct usb_serial_driver f81534a_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "f81534a",
},
.id_table = f81534a_id_table,

--
2.34.1

2024-03-28 22:10:29

by Krzysztof Kozlowski

Subject: [PATCH 12/52] USB: serial: ftdi_sio: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ftdi_sio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 76a04ab41100..c6f17d732b95 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -2871,7 +2871,6 @@ static int ftdi_ioctl(struct tty_struct *tty,

static struct usb_serial_driver ftdi_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ftdi_sio",
.dev_groups = ftdi_groups,
},

--
2.34.1

2024-03-28 22:10:44

by Krzysztof Kozlowski

Subject: [PATCH 13/52] USB: serial: garmin_gps: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/garmin_gps.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 670e942fdaaa..5e1244d87cf7 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -1413,7 +1413,6 @@ static void garmin_port_remove(struct usb_serial_port *port)
/* All of the device info needed */
static struct usb_serial_driver garmin_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "garmin_gps",
},
.description = "Garmin GPS usb/tty",

--
2.34.1

2024-03-28 22:10:59

by Krzysztof Kozlowski

Subject: [PATCH 14/52] USB: serial: generic: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/generic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 15b6dee3a8e5..757f0a586ddb 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -63,7 +63,6 @@ static int usb_serial_generic_calc_num_ports(struct usb_serial *serial,

static struct usb_serial_driver usb_serial_generic_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "generic",
},
.id_table = generic_device_ids,

--
2.34.1

2024-03-28 22:11:13

by Krzysztof Kozlowski

Subject: [PATCH 15/52] USB: serial: io_edgeport: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/io_edgeport.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
index abe4bbb0ac65..c7d6b5e3f898 100644
--- a/drivers/usb/serial/io_edgeport.c
+++ b/drivers/usb/serial/io_edgeport.c
@@ -2978,7 +2978,6 @@ static void edge_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver edgeport_2port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "edgeport_2",
},
.description = "Edgeport 2 port adapter",
@@ -3013,7 +3012,6 @@ static struct usb_serial_driver edgeport_2port_device = {

static struct usb_serial_driver edgeport_4port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "edgeport_4",
},
.description = "Edgeport 4 port adapter",
@@ -3048,7 +3046,6 @@ static struct usb_serial_driver edgeport_4port_device = {

static struct usb_serial_driver edgeport_8port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "edgeport_8",
},
.description = "Edgeport 8 port adapter",
@@ -3083,7 +3080,6 @@ static struct usb_serial_driver edgeport_8port_device = {

static struct usb_serial_driver epic_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "epic",
},
.description = "EPiC device",

--
2.34.1

2024-03-28 22:11:30

by Krzysztof Kozlowski

Subject: [PATCH 16/52] USB: serial: io_ti: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/io_ti.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 7a3a6e539456..7d0584b2a234 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -2670,7 +2670,6 @@ static int edge_resume(struct usb_serial *serial)

static struct usb_serial_driver edgeport_1port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "edgeport_ti_1",
},
.description = "Edgeport TI 1 port adapter",
@@ -2708,7 +2707,6 @@ static struct usb_serial_driver edgeport_1port_device = {

static struct usb_serial_driver edgeport_2port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "edgeport_ti_2",
},
.description = "Edgeport TI 2 port adapter",

--
2.34.1

2024-03-28 22:11:59

by Krzysztof Kozlowski

Subject: [PATCH 18/52] USB: serial: ipw: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ipw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ipw.c b/drivers/usb/serial/ipw.c
index d04c7cc5c1c2..b1e672c2f423 100644
--- a/drivers/usb/serial/ipw.c
+++ b/drivers/usb/serial/ipw.c
@@ -285,7 +285,6 @@ static void ipw_close(struct usb_serial_port *port)

static struct usb_serial_driver ipw_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ipw",
},
.description = "IPWireless converter",

--
2.34.1

2024-03-28 22:12:14

by Krzysztof Kozlowski

Subject: [PATCH 19/52] USB: serial: ir-usb: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ir-usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c
index 82f108134e6f..a106b71e698f 100644
--- a/drivers/usb/serial/ir-usb.c
+++ b/drivers/usb/serial/ir-usb.c
@@ -71,7 +71,6 @@ MODULE_DEVICE_TABLE(usb, ir_id_table);

static struct usb_serial_driver ir_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ir-usb",
},
.description = "IR Dongle",

--
2.34.1

2024-03-28 22:12:19

by Krzysztof Kozlowski

Subject: [PATCH 10/52] USB: serial: empeg: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/empeg.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c
index 405e835e93dd..aedcf7ebd269 100644
--- a/drivers/usb/serial/empeg.c
+++ b/drivers/usb/serial/empeg.c
@@ -43,7 +43,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver empeg_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "empeg",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:12:31

by Krzysztof Kozlowski

Subject: [PATCH 20/52] USB: serial: iuu: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/iuu_phoenix.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index 77cba71bcccb..c21dcc9b6f05 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -1157,7 +1157,6 @@ static int iuu_remove_sysfs_attrs(struct usb_serial_port *port)

static struct usb_serial_driver iuu_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "iuu_phoenix",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:12:46

by Krzysztof Kozlowski

Subject: [PATCH 21/52] USB: serial: keyspan: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/keyspan.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 0a783985197c..9129e0282c24 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -3001,7 +3001,6 @@ static void keyspan_port_remove(struct usb_serial_port *port)
/* Structs for the devices, pre and post renumeration. */
static struct usb_serial_driver keyspan_pre_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_no_firm",
},
.description = "Keyspan - (without firmware)",
@@ -3012,7 +3011,6 @@ static struct usb_serial_driver keyspan_pre_device = {

static struct usb_serial_driver keyspan_1port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_1",
},
.description = "Keyspan 1 port adapter",
@@ -3036,7 +3034,6 @@ static struct usb_serial_driver keyspan_1port_device = {

static struct usb_serial_driver keyspan_2port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_2",
},
.description = "Keyspan 2 port adapter",
@@ -3060,7 +3057,6 @@ static struct usb_serial_driver keyspan_2port_device = {

static struct usb_serial_driver keyspan_4port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_4",
},
.description = "Keyspan 4 port adapter",

--
2.34.1

2024-03-28 22:13:00

by Krzysztof Kozlowski

Subject: [PATCH 22/52] USB: serial: keyspan_pda: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/keyspan_pda.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index 0eef358b314a..e98b479593d3 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -676,7 +676,6 @@ static void keyspan_pda_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver keyspan_pda_fake_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_pda_pre",
},
.description = "Keyspan PDA - (prerenumeration)",
@@ -687,7 +686,6 @@ static struct usb_serial_driver keyspan_pda_fake_device = {

static struct usb_serial_driver keyspan_pda_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "keyspan_pda",
},
.description = "Keyspan PDA",

--
2.34.1

2024-03-28 22:13:16

by Krzysztof Kozlowski

Subject: [PATCH 23/52] USB: serial: kl5kusb105: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/kl5kusb105.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 394b3189e003..a2c0bebc041f 100644
--- a/drivers/usb/serial/kl5kusb105.c
+++ b/drivers/usb/serial/kl5kusb105.c
@@ -75,7 +75,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver kl5kusb105d_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "kl5kusb105d",
},
.description = "KL5KUSB105D / PalmConnect",

--
2.34.1

2024-03-28 22:13:31

by Krzysztof Kozlowski

Subject: [PATCH 24/52] USB: serial: kobil_sct: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/kobil_sct.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index 5e775f68fcb8..5eb59ac3e564 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -77,7 +77,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver kobil_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "kobil",
},
.description = "KOBIL USB smart card terminal",

--
2.34.1

2024-03-28 22:13:47

by Krzysztof Kozlowski

Subject: [PATCH 25/52] USB: serial: mct_u232: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/mct_u232.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 6570c8817a80..e5a139ed5d90 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -69,7 +69,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver mct_u232_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "mct_u232",
},
.description = "MCT U232",

--
2.34.1

2024-03-28 22:14:02

by Krzysztof Kozlowski

Subject: [PATCH 26/52] USB: serial: metro_usb: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/metro-usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
index 30ab565e0738..028878292901 100644
--- a/drivers/usb/serial/metro-usb.c
+++ b/drivers/usb/serial/metro-usb.c
@@ -341,7 +341,6 @@ static void metrousb_unthrottle(struct tty_struct *tty)

static struct usb_serial_driver metrousb_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "metro-usb",
},
.description = "Metrologic USB to Serial",

--
2.34.1

2024-03-28 22:14:17

by Krzysztof Kozlowski

Subject: [PATCH 27/52] USB: serial: mos7720: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/mos7720.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 23544074eb1c..e59bfa7c8030 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -1724,7 +1724,6 @@ static void mos7720_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver moschip7720_2port_driver = {
.driver = {
- .owner = THIS_MODULE,
.name = "moschip7720",
},
.description = "Moschip 2 port adapter",

--
2.34.1

2024-03-28 22:14:31

by Krzysztof Kozlowski

Subject: [PATCH 17/52] USB: serial: ipaq: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ipaq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index e11441bac44f..3c6a9b9b9c2b 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -496,7 +496,6 @@ MODULE_DEVICE_TABLE(usb, ipaq_id_table);
/* All of the device info needed for the Compaq iPAQ */
static struct usb_serial_driver ipaq_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ipaq",
},
.description = "PocketPC PDA",

--
2.34.1

2024-03-28 22:14:39

by Krzysztof Kozlowski

Subject: [PATCH 28/52] USB: serial: mos7840: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/mos7840.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 8b0308d84270..70ff2408b99a 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -1739,7 +1739,6 @@ static void mos7840_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver moschip7840_4port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "mos7840",
},
.description = DRIVER_DESC,

--
2.34.1

2024-03-28 22:14:55

by Krzysztof Kozlowski

Subject: [PATCH 29/52] USB: serial: mxuport: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/mxuport.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c
index 1f7bb3e4fcf2..2188e9668c41 100644
--- a/drivers/usb/serial/mxuport.c
+++ b/drivers/usb/serial/mxuport.c
@@ -1278,7 +1278,6 @@ static int mxuport_resume(struct usb_serial *serial)

static struct usb_serial_driver mxuport_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "mxuport",
},
.description = "MOXA UPort",

--
2.34.1

2024-03-28 22:15:10

by Krzysztof Kozlowski

Subject: [PATCH 30/52] USB: serial: navman: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/navman.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/navman.c b/drivers/usb/serial/navman.c
index 20277c52dded..99b633051729 100644
--- a/drivers/usb/serial/navman.c
+++ b/drivers/usb/serial/navman.c
@@ -95,7 +95,6 @@ static int navman_write(struct tty_struct *tty, struct usb_serial_port *port,

static struct usb_serial_driver navman_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "navman",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:15:23

by Krzysztof Kozlowski

Subject: [PATCH 31/52] USB: serial: omninet: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/omninet.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 41f1b872d277..397ebd5a3e74 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -49,7 +49,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver zyxel_omninet_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "omninet",
},
.description = "ZyXEL - omni.net usb",

--
2.34.1

2024-03-28 22:15:37

by Krzysztof Kozlowski

Subject: [PATCH 32/52] USB: serial: opticon: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/opticon.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index e31a6d77da3a..1ee84ccc4bbd 100644
--- a/drivers/usb/serial/opticon.c
+++ b/drivers/usb/serial/opticon.c
@@ -375,7 +375,6 @@ static void opticon_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver opticon_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "opticon",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:15:51

by Krzysztof Kozlowski

Subject: [PATCH 33/52] USB: serial: option: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/option.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 55a65d941ccb..d1598d665a5c 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2298,7 +2298,6 @@ MODULE_DEVICE_TABLE(usb, option_ids);

static struct usb_serial_driver option_1port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "option1",
},
.description = "GSM modem (1-port)",

--
2.34.1

2024-03-28 22:16:04

by Krzysztof Kozlowski

Subject: [PATCH 34/52] USB: serial: oti6858: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/oti6858.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index fa07f6ff9ecc..24068368892c 100644
--- a/drivers/usb/serial/oti6858.c
+++ b/drivers/usb/serial/oti6858.c
@@ -138,7 +138,6 @@ static void oti6858_port_remove(struct usb_serial_port *port);
/* device info */
static struct usb_serial_driver oti6858_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "oti6858",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:16:16

by Krzysztof Kozlowski

Subject: [PATCH 35/52] USB: serial: pl2303: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/pl2303.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index d93f5d584557..9e3b524a2e7b 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -1234,7 +1234,6 @@ static void pl2303_process_read_urb(struct urb *urb)

static struct usb_serial_driver pl2303_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "pl2303",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:16:42

by Krzysztof Kozlowski

Subject: [PATCH 37/52] USB: serial: qcserial: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/qcserial.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 703a9c563557..c7de9585feb2 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -454,7 +454,6 @@ static void qc_release(struct usb_serial *serial)

static struct usb_serial_driver qcdevice = {
.driver = {
- .owner = THIS_MODULE,
.name = "qcserial",
},
.description = "Qualcomm USB modem",

--
2.34.1

2024-03-28 22:16:59

by Krzysztof Kozlowski

Subject: [PATCH 38/52] USB: serial: quatech2: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/quatech2.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 821f25e52ec2..4167a45d1be3 100644
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -924,7 +924,6 @@ static int qt2_write(struct tty_struct *tty,

static struct usb_serial_driver qt2_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "quatech-serial",
},
.description = DRIVER_DESC,

--
2.34.1

2024-03-28 22:17:18

by Krzysztof Kozlowski

Subject: [PATCH 39/52] USB: serial: safe_serial: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/safe_serial.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c
index 6accbecb6318..238b54993446 100644
--- a/drivers/usb/serial/safe_serial.c
+++ b/drivers/usb/serial/safe_serial.c
@@ -284,7 +284,6 @@ static int safe_startup(struct usb_serial *serial)

static struct usb_serial_driver safe_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "safe_serial",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:17:37

by Krzysztof Kozlowski

Subject: [PATCH 40/52] USB: serial: sierra: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/sierra.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 353b2549eaa8..64a2e0bb5723 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -1021,7 +1021,6 @@ static int sierra_resume(struct usb_serial *serial)

static struct usb_serial_driver sierra_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "sierra",
},
.description = "Sierra USB modem",

--
2.34.1

2024-03-28 22:17:50

by Krzysztof Kozlowski

Subject: [PATCH 41/52] USB: serial: spcp8x5: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/spcp8x5.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 09a972a838ee..0d3ac5a56983 100644
--- a/drivers/usb/serial/spcp8x5.c
+++ b/drivers/usb/serial/spcp8x5.c
@@ -462,7 +462,6 @@ static int spcp8x5_tiocmget(struct tty_struct *tty)

static struct usb_serial_driver spcp8x5_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "SPCP8x5",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:18:03

by Krzysztof Kozlowski

Subject: [PATCH 42/52] USB: serial: ssu100: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ssu100.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 1e1888b66305..df21009bdf42 100644
--- a/drivers/usb/serial/ssu100.c
+++ b/drivers/usb/serial/ssu100.c
@@ -500,7 +500,6 @@ static void ssu100_process_read_urb(struct urb *urb)

static struct usb_serial_driver ssu100_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ssu100",
},
.description = DRIVER_DESC,

--
2.34.1

2024-03-28 22:18:19

by Krzysztof Kozlowski

Subject: [PATCH 43/52] USB: serial: symbol: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/symbolserial.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c
index d7f73ad6e778..52a73812afac 100644
--- a/drivers/usb/serial/symbolserial.c
+++ b/drivers/usb/serial/symbolserial.c
@@ -169,7 +169,6 @@ static void symbol_port_remove(struct usb_serial_port *port)

static struct usb_serial_driver symbol_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "symbol",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:18:30

by Krzysztof Kozlowski

Subject: [PATCH 44/52] USB: serial: ti_usb_3410_5052: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/ti_usb_3410_5052.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
index 0fba25abf671..a0c244bc77c0 100644
--- a/drivers/usb/serial/ti_usb_3410_5052.c
+++ b/drivers/usb/serial/ti_usb_3410_5052.c
@@ -417,7 +417,6 @@ static const struct usb_device_id ti_id_table_combined[] = {

static struct usb_serial_driver ti_1port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ti_usb_3410_5052_1",
},
.description = "TI USB 3410 1 port adapter",
@@ -450,7 +449,6 @@ static struct usb_serial_driver ti_1port_device = {

static struct usb_serial_driver ti_2port_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "ti_usb_3410_5052_2",
},
.description = "TI USB 5052 2 port adapter",

--
2.34.1

2024-03-28 22:18:42

by Krzysztof Kozlowski

Subject: [PATCH 45/52] USB: serial: upd78f0730: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/upd78f0730.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c
index 46952182e04f..15a17bf111f1 100644
--- a/drivers/usb/serial/upd78f0730.c
+++ b/drivers/usb/serial/upd78f0730.c
@@ -407,7 +407,6 @@ static void upd78f0730_close(struct usb_serial_port *port)

static struct usb_serial_driver upd78f0730_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "upd78f0730",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:19:09

by Krzysztof Kozlowski

Subject: [PATCH 47/52] USB: serial: debug: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/usb_debug.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c
index 6934970f180d..840373b965fc 100644
--- a/drivers/usb/serial/usb_debug.c
+++ b/drivers/usb/serial/usb_debug.c
@@ -78,7 +78,6 @@ static void usb_debug_process_read_urb(struct urb *urb)

static struct usb_serial_driver debug_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "debug",
},
.id_table = id_table,
@@ -90,7 +89,6 @@ static struct usb_serial_driver debug_device = {

static struct usb_serial_driver dbc_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "xhci_dbc",
},
.id_table = dbc_id_table,

--
2.34.1

2024-03-28 22:19:36

by Krzysztof Kozlowski

Subject: [PATCH 49/52] USB: serial: whiteheat: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/whiteheat.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index ca48e90a8e81..009faeb2ef55 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -91,7 +91,6 @@ static int whiteheat_break_ctl(struct tty_struct *tty, int break_state);

static struct usb_serial_driver whiteheat_fake_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "whiteheatnofirm",
},
.description = "Connect Tech - WhiteHEAT - (prerenumeration)",
@@ -103,7 +102,6 @@ static struct usb_serial_driver whiteheat_fake_device = {

static struct usb_serial_driver whiteheat_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "whiteheat",
},
.description = "Connect Tech - WhiteHEAT",

--
2.34.1

2024-03-28 22:19:43

by Krzysztof Kozlowski

Subject: [PATCH 48/52] USB: serial: visor: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/visor.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 4412834db21c..062a38fe0c1c 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(usb, id_table_combined);
and Palm 4.0 devices */
static struct usb_serial_driver handspring_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "visor",
},
.description = "Handspring Visor / Palm OS",
@@ -180,7 +179,6 @@ static struct usb_serial_driver handspring_device = {
/* All of the device info needed for the Clie UX50, TH55 Palm 5.0 devices */
static struct usb_serial_driver clie_5_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "clie_5",
},
.description = "Sony Clie 5.0",
@@ -200,7 +198,6 @@ static struct usb_serial_driver clie_5_device = {
/* device info for the Sony Clie OS version 3.5 */
static struct usb_serial_driver clie_3_5_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "clie_3.5",
},
.description = "Sony Clie 3.5",

--
2.34.1

2024-03-28 22:19:47

by Krzysztof Kozlowski

Subject: [PATCH 36/52] USB: serial: qcaux: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/qcaux.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c
index 929ffba663f2..fd34f7e48e53 100644
--- a/drivers/usb/serial/qcaux.c
+++ b/drivers/usb/serial/qcaux.c
@@ -72,7 +72,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver qcaux_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "qcaux",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:19:49

by Krzysztof Kozlowski

Subject: [PATCH 50/52] USB: serial: wishbone: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/wishbone-serial.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/wishbone-serial.c b/drivers/usb/serial/wishbone-serial.c
index ff4092f9b33c..670d573f6b63 100644
--- a/drivers/usb/serial/wishbone-serial.c
+++ b/drivers/usb/serial/wishbone-serial.c
@@ -70,7 +70,6 @@ static void wishbone_serial_close(struct usb_serial_port *port)

static struct usb_serial_driver wishbone_serial_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "wishbone_serial",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:20:15

by Krzysztof Kozlowski

Subject: [PATCH 52/52] USB: serial: xsens_mt: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/xsens_mt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index cf262c9a9638..382b3698c1d5 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial/xsens_mt.c
@@ -49,7 +49,6 @@ static int xsens_mt_probe(struct usb_serial *serial,

static struct usb_serial_driver xsens_mt_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "xsens_mt",
},
.id_table = id_table,

--
2.34.1

2024-03-28 22:21:47

by Krzysztof Kozlowski

Subject: [PATCH 46/52] USB: serial: simple: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/usb-serial-simple.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 24b8772a345e..d733b31fe51b 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -24,7 +24,6 @@ static const struct usb_device_id vendor##_id_table[] = { \
}; \
static struct usb_serial_driver vendor##_device = { \
.driver = { \
- .owner = THIS_MODULE, \
.name = #vendor, \
}, \
.id_table = vendor##_id_table, \

--
2.34.1

2024-03-28 22:22:42

by Krzysztof Kozlowski

Subject: [PATCH 51/52] USB: serial: xr: drop driver owner initialization

Core in usb_serial_register_drivers() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/usb/serial/xr_serial.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c
index 1d9a12628f81..4186e791b384 100644
--- a/drivers/usb/serial/xr_serial.c
+++ b/drivers/usb/serial/xr_serial.c
@@ -1082,7 +1082,6 @@ MODULE_DEVICE_TABLE(usb, id_table);

static struct usb_serial_driver xr_device = {
.driver = {
- .owner = THIS_MODULE,
.name = "xr_serial",
},
.id_table = id_table,

--
2.34.1

2024-04-15 08:54:33

by Johan Hovold

Subject: Re: [PATCH 00/52] USB: store owner from modules with usb_serial_register_drivers()

On Thu, Mar 28, 2024 at 11:05:38PM +0100, Krzysztof Kozlowski wrote:
> Merging
> =======
> All further patches depend on the first patch.
>
> Description
> ===========
> This is going to be a bit of a patch-bomb, but with trivial patches, so
> I think it is still acceptable. If it is too much, apologies and I will
> solve it.

No, sending 51 trivial one-line cleanup patches like this is not
acceptable.

This is just one logical change so squash them all into one patch for
the entire subsystem (i.e. this series should contain two patches).

> Modules registering driver with usb_serial_register_drivers() might
> forget to set .owner field.
>
> Solve the problem by moving this task away from the drivers to the core
> amba bus code, just like we did for platform_driver in commit

"amba" copy pasta.

> 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").

> Krzysztof Kozlowski (52):
> USB: serial: store owner from modules with usb_serial_register_drivers()
> USB: serial: aircable: drop driver owner initialization
..
> USB: serial: xsens_mt: drop driver owner initialization

> 53 files changed, 12 insertions(+), 75 deletions(-)

Johan