2024-04-17 20:07:58

by Konrad Dybcio

Subject: [PATCH 1/2] iommu/qcom: Remove useless forward definition

Simply move code around.

Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index e079bb7a993e..3dca9293c509 100644
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -41,7 +41,14 @@ enum qcom_iommu_clk {
CLK_NUM,
};

-struct qcom_iommu_ctx;
+struct qcom_iommu_ctx {
+ struct device *dev;
+ void __iomem *base;
+ bool secure_init;
+ bool secured_ctx;
+ u8 asid; /* asid and ctx bank # are 1:1 */
+ struct iommu_domain *domain;
+};

struct qcom_iommu_dev {
/* IOMMU core code handle */
@@ -54,15 +61,6 @@ struct qcom_iommu_dev {
struct qcom_iommu_ctx *ctxs[]; /* indexed by asid */
};

-struct qcom_iommu_ctx {
- struct device *dev;
- void __iomem *base;
- bool secure_init;
- bool secured_ctx;
- u8 asid; /* asid and ctx bank # are 1:1 */
- struct iommu_domain *domain;
-};
-
struct qcom_iommu_domain {
struct io_pgtable_ops *pgtbl_ops;
spinlock_t pgtbl_lock;

--
2.44.0

2024-04-17 20:36:43

by Bjorn Andersson

Subject: Re: [PATCH 1/2] iommu/qcom: Remove useless forward definition

On Wed, Apr 17, 2024 at 10:06:59PM +0200, Konrad Dybcio wrote:
> Simply move code around.

Aint much of a motivation for the change in those words...
Please do express a problem statement in your changes, even though if
seems obvious to many why you would be doing this.

Perhaps your obvious reason is not the same as my obvious reason? Now we
will never know!

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> drivers/iommu/arm/arm-smmu/qcom_iommu.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
> index e079bb7a993e..3dca9293c509 100644
> --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
> +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
> @@ -41,7 +41,14 @@ enum qcom_iommu_clk {
> CLK_NUM,
> };
>
> -struct qcom_iommu_ctx;
> +struct qcom_iommu_ctx {
> + struct device *dev;
> + void __iomem *base;
> + bool secure_init;
> + bool secured_ctx;
> + u8 asid; /* asid and ctx bank # are 1:1 */
> + struct iommu_domain *domain;
> +};
>
> struct qcom_iommu_dev {
> /* IOMMU core code handle */
> @@ -54,15 +61,6 @@ struct qcom_iommu_dev {
> struct qcom_iommu_ctx *ctxs[]; /* indexed by asid */
> };
>
> -struct qcom_iommu_ctx {
> - struct device *dev;
> - void __iomem *base;
> - bool secure_init;
> - bool secured_ctx;
> - u8 asid; /* asid and ctx bank # are 1:1 */
> - struct iommu_domain *domain;
> -};
> -
> struct qcom_iommu_domain {
> struct io_pgtable_ops *pgtbl_ops;
> spinlock_t pgtbl_lock;
>
> --
> 2.44.0
>