2024-04-17 03:57:15

by Xiu Jianfeng

Subject: [PATCH -next] cgroup_freezer: update comment for freezer_css_online()

From: Xiu Jianfeng <[email protected]>

The freezer->lock was replaced by freezer_mutex in commit e5ced8ebb10c
("cgroup_freezer: replace freezer->lock with freezer_mutex"), so the
comment here is out-of-date, update it.

Signed-off-by: Xiu Jianfeng <[email protected]>
---
kernel/cgroup/legacy_freezer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/cgroup/legacy_freezer.c b/kernel/cgroup/legacy_freezer.c
index 66d1708042a7..d598cc6ee92e 100644
--- a/kernel/cgroup/legacy_freezer.c
+++ b/kernel/cgroup/legacy_freezer.c
@@ -106,8 +106,7 @@ freezer_css_alloc(struct cgroup_subsys_state *parent_css)
* @css: css being created
*
* We're committing to creation of @css. Mark it online and inherit
- * parent's freezing state while holding both parent's and our
- * freezer->lock.
+ * parent's freezing state while holding cpus read lock and freezer_mutex.
*/
static int freezer_css_online(struct cgroup_subsys_state *css)
{
--
2.34.1

2024-04-18 02:00:57

by Tejun Heo

Subject: Re: [PATCH -next] cgroup_freezer: update comment for freezer_css_online()

On Wed, Apr 17, 2024 at 03:50:28AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <[email protected]>
>
> The freezer->lock was replaced by freezer_mutex in commit e5ced8ebb10c
> ("cgroup_freezer: replace freezer->lock with freezer_mutex"), so the
> comment here is out-of-date, update it.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>

Applied to cgroup/for-6.10.

Thanks.

--
tejun