2024-04-17 15:37:57

by Fabio Aiuto

[permalink] [raw]
Subject: [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support

Update bindings for pca9451a support.

Cc: Matteo Lisi <[email protected]>
Cc: Mirko Ardinghi <[email protected]>
Signed-off-by: Fabio Aiuto <[email protected]>
---
.../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index 3d469b8e9774..849bfa50bdba 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -28,6 +28,7 @@ properties:
- nxp,pca9450a
- nxp,pca9450b
- nxp,pca9450c
+ - nxp,pca9451a

reg:
maxItems: 1
--
2.34.1



2024-04-17 17:06:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support

On 17/04/2024 17:35, Fabio Aiuto wrote:
> Update bindings for pca9451a support.
>
> Cc: Matteo Lisi <[email protected]>
> Cc: Mirko Ardinghi <[email protected]>
> Signed-off-by: Fabio Aiuto <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-04-18 00:38:25

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support

On Wed, Apr 17, 2024 at 05:35:26PM +0200, Fabio Aiuto wrote:
> Update bindings for pca9451a support.

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.

Attachments:
(No filename) (405.00 B)
 signature.asc (499.00 B)
 Download all attachments

2024-04-18 07:34:45

by Fabio Aiuto

[permalink] [raw]
Subject: Re: [PATCH 2/4] regulator: dt-bindings: pca9450: add pca9451a support

Dear Mark,

Il Thu, Apr 18, 2024 at 09:38:06AM +0900, Mark Brown ha scritto:
> On Wed, Apr 17, 2024 at 05:35:26PM +0200, Fabio Aiuto wrote:
> > Update bindings for pca9451a support.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.

thank you, I was in doubt because I did the whole job based on
shawnguo's repo where the patch isn't applied yet.

Maybe this approach was not good, should I have considered broonie's
repo for this single patch, shouldn't I?

Anyway I'm dropping this patch for a v2.

kr,

fabio