2024-04-15 14:25:07

by Andy Shevchenko

Subject: [PATCH v1 1/1] fpga: ice40-spi: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <[email protected]>
---

This is a replacement of previously sent:
fpga: ice40-spi: Remove unused of_gpio.h
fpga: ice40-spi: Remove redundant of_match_ptr() macros

drivers/fpga/ice40-spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
index c0028ae4c5b7..62c30266130d 100644
--- a/drivers/fpga/ice40-spi.c
+++ b/drivers/fpga/ice40-spi.c
@@ -10,8 +10,8 @@

#include <linux/fpga/fpga-mgr.h>
#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/spi/spi.h>
#include <linux/stringify.h>

@@ -199,7 +199,7 @@ static struct spi_driver ice40_fpga_driver = {
.probe = ice40_fpga_probe,
.driver = {
.name = "ice40spi",
- .of_match_table = of_match_ptr(ice40_fpga_of_match),
+ .of_match_table = ice40_fpga_of_match,
},
.id_table = ice40_fpga_spi_ids,
};
--
2.43.0.rc1.1336.g36b5255a03ac

2024-04-19 07:40:59

by Xu Yilun

Subject: Re: [PATCH v1 1/1] fpga: ice40-spi: Don't use "proxy" headers

On Mon, Apr 15, 2024 at 05:23:28PM +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Xu Yilun <[email protected]>

Applied to for-next.

> ---
>
> This is a replacement of previously sent:
> fpga: ice40-spi: Remove unused of_gpio.h
> fpga: ice40-spi: Remove redundant of_match_ptr() macros
>
> drivers/fpga/ice40-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
> index c0028ae4c5b7..62c30266130d 100644
> --- a/drivers/fpga/ice40-spi.c
> +++ b/drivers/fpga/ice40-spi.c
> @@ -10,8 +10,8 @@
>
> #include <linux/fpga/fpga-mgr.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/spi/spi.h>
> #include <linux/stringify.h>
>
> @@ -199,7 +199,7 @@ static struct spi_driver ice40_fpga_driver = {
> .probe = ice40_fpga_probe,
> .driver = {
> .name = "ice40spi",
> - .of_match_table = of_match_ptr(ice40_fpga_of_match),
> + .of_match_table = ice40_fpga_of_match,
> },
> .id_table = ice40_fpga_spi_ids,
> };
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>