2024-04-15 23:58:29

by Colberg, Peter

Subject: [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present

The function is_dfl_feature_present was added but never used.

Fixes: 5b57d02a2f94 ("fpga: dfl: add feature device infrastructure")
Signed-off-by: Peter Colberg <[email protected]>
Reviewed-by: Matthew Gerlach <[email protected]>
---
v2:
- Do not wrap commit reference and move to Fixes: tag.
---
drivers/fpga/dfl.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
index 1d724a28f00a..5063d73b0d82 100644
--- a/drivers/fpga/dfl.h
+++ b/drivers/fpga/dfl.h
@@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
return NULL;
}

-static inline bool is_dfl_feature_present(struct device *dev, u16 id)
-{
- return !!dfl_get_feature_ioaddr_by_id(dev, id);
-}
-
static inline
struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
{
--
2.44.0

2024-04-19 07:57:45

by Xu Yilun

Subject: Re: [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present

On Mon, Apr 15, 2024 at 07:57:43PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added but never used.
^

Function reference should use the format "function_name()", I fixed it
in place.

Applied to for-next.

>
> Fixes: 5b57d02a2f94 ("fpga: dfl: add feature device infrastructure")
> Signed-off-by: Peter Colberg <[email protected]>
> Reviewed-by: Matthew Gerlach <[email protected]>
> ---
> v2:
> - Do not wrap commit reference and move to Fixes: tag.
> ---
> drivers/fpga/dfl.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
> return NULL;
> }
>
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> - return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
> static inline
> struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
> {
> --
> 2.44.0
>
>