2024-04-22 13:52:14

by Kory Maincent

[permalink] [raw]
Subject: [PATCH net-next v2 0/3] net: pse-pd: Fixes for few small issues

From: Kory Maincent (Dent Project) <[email protected]>

This patch series fix few issues in PSE net subsystem like Regulator
dependency, PSE regulator type and kernel Documentation.

Signed-off-by: Kory Maincent <[email protected]>
---
Changes in v2:
- Remove "Dent project" from my sob.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Kory Maincent (Dent Project) (3):
net: pse-pd: pse_core: Add missing kdoc return description
net: pse-pd: pse_core: Fix pse regulator type
net: pse-pd: Kconfig: Add missing Regulator API dependency

drivers/net/pse-pd/Kconfig | 2 +-
drivers/net/pse-pd/pse_core.c | 10 +++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 6a57f091622a1251c2826f7380577049199b80ea
change-id: 20240422-fix_poe-d0fb292c9d8e

Best regards,
--
K?ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com



2024-04-22 13:52:24

by Kory Maincent

[permalink] [raw]
Subject: [PATCH net-next v2 1/3] net: pse-pd: pse_core: Add missing kdoc return description

From: Kory Maincent (Dent Project) <[email protected]>

Add missing kernel documentation return description.
This allows to remove all warning from kernel-doc test script.

Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Kory Maincent <[email protected]>
---
drivers/net/pse-pd/pse_core.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index 31f23c454678..bad29eaa4d01 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -320,6 +320,8 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
/**
* pse_controller_register - register a PSE controller device
* @pcdev: a pointer to the initialized PSE controller device
+ *
+ * Return: 0 on success and failure value on error
*/
int pse_controller_register(struct pse_controller_dev *pcdev)
{
@@ -401,6 +403,8 @@ static void devm_pse_controller_release(struct device *dev, void *res)
* Managed pse_controller_register(). For PSE controllers registered by
* this function, pse_controller_unregister() is automatically called on
* driver detach. See pse_controller_register() for more information.
+ *
+ * Return: 0 on success and failure value on error
*/
int devm_pse_controller_register(struct device *dev,
struct pse_controller_dev *pcdev)
@@ -627,6 +631,8 @@ EXPORT_SYMBOL_GPL(of_pse_control_get);
* @psec: PSE control pointer
* @extack: extack for reporting useful error messages
* @status: struct to store PSE status
+ *
+ * Return: 0 on success and failure value on error
*/
int pse_ethtool_get_status(struct pse_control *psec,
struct netlink_ext_ack *extack,
@@ -704,6 +710,8 @@ static int pse_ethtool_podl_set_config(struct pse_control *psec,
* @psec: PSE control pointer
* @extack: extack for reporting useful error messages
* @config: Configuration of the test to run
+ *
+ * Return: 0 on success and failure value on error
*/
int pse_ethtool_set_config(struct pse_control *psec,
struct netlink_ext_ack *extack,

--
2.34.1


2024-04-23 08:49:39

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH net-next v2 1/3] net: pse-pd: pse_core: Add missing kdoc return description

On Mon, Apr 22, 2024 at 03:35:46PM +0200, Kory Maincent (Dent Project) wrote:
> From: Kory Maincent (Dent Project) <[email protected]>
>
> Add missing kernel documentation return description.
> This allows to remove all warning from kernel-doc test script.
>
> Reviewed-by: Andrew Lunn <[email protected]>
> Signed-off-by: Kory Maincent <[email protected]>

Acked-by: Oleksij Rempel <[email protected]>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |