The modpost script is not happy
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
because there is a missing module description.
Add it to the module.
Signed-off-by: Andy Shevchenko <[email protected]>
---
v2: alinged text with Kconfig entry (Thadeu Lima)
drivers/platform/x86/classmate-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 87462e7c6219..cb6fce655e35 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -13,8 +13,6 @@
#include <linux/input.h>
#include <linux/rfkill.h>
-MODULE_LICENSE("GPL");
-
struct cmpc_accel {
int sensitivity;
int g_select;
@@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
};
MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
+MODULE_DESCRIPTION("Support for Intel Classmate PC ACPI devices");
+MODULE_LICENSE("GPL");
--
2.43.0.rc1.1336.g36b5255a03ac
On Tue, Apr 23, 2024 at 07:09:51PM +0300, Andy Shevchenko wrote:
> The modpost script is not happy
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
>
> because there is a missing module description.
>
> Add it to the module.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> v2: alinged text with Kconfig entry (Thadeu Lima)
> drivers/platform/x86/classmate-laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 87462e7c6219..cb6fce655e35 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -13,8 +13,6 @@
> #include <linux/input.h>
> #include <linux/rfkill.h>
>
> -MODULE_LICENSE("GPL");
> -
> struct cmpc_accel {
> int sensitivity;
> int g_select;
> @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
> };
>
> MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
> +MODULE_DESCRIPTION("Support for Intel Classmate PC ACPI devices");
> +MODULE_LICENSE("GPL");
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
Acked-by: Thadeu Lima de Souza Cascardo <[email protected]>
Hi,
On 4/23/24 6:09 PM, Andy Shevchenko wrote:
> The modpost script is not happy
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o
>
> because there is a missing module description.
>
> Add it to the module.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> v2: alinged text with Kconfig entry (Thadeu Lima)
> drivers/platform/x86/classmate-laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 87462e7c6219..cb6fce655e35 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -13,8 +13,6 @@
> #include <linux/input.h>
> #include <linux/rfkill.h>
>
> -MODULE_LICENSE("GPL");
> -
> struct cmpc_accel {
> int sensitivity;
> int g_select;
> @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = {
> };
>
> MODULE_DEVICE_TABLE(acpi, cmpc_device_ids);
> +MODULE_DESCRIPTION("Support for Intel Classmate PC ACPI devices");
> +MODULE_LICENSE("GPL");