2024-04-30 23:47:48

by Jules Irenge

Subject: [PATCH] RDMA/ipoib: Remove NULL check before dev_{put, hold}

Coccinelle reports a warning

WARNING: NULL check before dev_{put, hold} functions is not needed

The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL
There is no need to check before using dev_{put, hold}

Signed-off-by: Jules Irenge <[email protected]>
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 6f2a688fccbf..4abec0124ea3 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -329,8 +329,7 @@ static struct net_device *ipoib_get_master_net_dev(struct net_device *dev)

rcu_read_lock();
master = netdev_master_upper_dev_get_rcu(dev);
- if (master)
- dev_hold(master);
+ dev_hold(master);
rcu_read_unlock();

if (master)
--
2.43.2

2024-05-02 15:01:42

by Leon Romanovsky

Subject: Re: [PATCH] RDMA/ipoib: Remove NULL check before dev_{put, hold}

On Wed, 01 May 2024 00:47:33 +0100, Jules Irenge wrote:
> Coccinelle reports a warning
>
> WARNING: NULL check before dev_{put, hold} functions is not needed
>
> The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL
> There is no need to check before using dev_{put, hold}
>
> [...]

Applied, thanks!

[1/1] RDMA/ipoib: Remove NULL check before dev_{put, hold}
https://git.kernel.org/rdma/rdma/c/e4e40a87024c50

Best regards,
--
Leon Romanovsky <[email protected]>