2024-05-06 18:02:28

by Ian Rogers

Subject: [PATCH v7 1/4] perf map: Add missing dso__put in map__new

A dso__put is needed for the dsos__find when the map is created and a
buildid is sought.

Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking")
Signed-off-by: Ian Rogers <[email protected]>
---
tools/perf/util/map.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 117c4bb78b35..e1d14936a60d 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -200,6 +200,7 @@ struct map *map__new(struct machine *machine, u64 start, u64 len,
dso__set_build_id(dso, dso__bid(header_bid_dso));
dso__set_header_build_id(dso, 1);
}
+ dso__put(header_bid_dso);
}
dso__put(dso);
}
--
2.45.0.rc1.225.g2a3ae87e7f-goog

2024-05-06 18:36:21

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH v7 1/4] perf map: Add missing dso__put in map__new

On Mon, May 06, 2024 at 11:01:01AM -0700, Ian Rogers wrote:
> A dso__put is needed for the dsos__find when the map is created and a
> buildid is sought.

> Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking")

I just sent a reply asking you to do this, thanks a lot for adding the
Fixes tag, processing this new series now.

- Arnaldo

> Signed-off-by: Ian Rogers <[email protected]>
> ---
> tools/perf/util/map.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index 117c4bb78b35..e1d14936a60d 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -200,6 +200,7 @@ struct map *map__new(struct machine *machine, u64 start, u64 len,
> dso__set_build_id(dso, dso__bid(header_bid_dso));
> dso__set_header_build_id(dso, 1);
> }
> + dso__put(header_bid_dso);
> }
> dso__put(dso);
> }
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>