2024-05-22 10:10:03

by Lukas Wunner

[permalink] [raw]
Subject: Re: [REPOST PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes from reading too many bytes

On Tue, May 21, 2024 at 06:50:06PM -0400, Stefan Berger wrote:
> Prevent ecc_digits_from_bytes from reading too many bytes from the input
> byte array in case an insufficient number of bytes is provided to fill the
> output digit array of ndigits. Therefore, initialize the most significant
> digits with 0 to avoid trying to read too many bytes later on. Convert the
> function into a regular function since it is getting too big for an inline
> function.
>
> If too many bytes are provided on the input byte array the extra bytes
> are ignored since the input variable 'ndigits' limits the number of digits
> that will be filled.
>
> Fixes: d67c96fb97b5 ("crypto: ecdsa - Convert byte arrays with key coordinates to digits")
> Reviewed-by: Jarkko Sakkinen <[email protected]>
> Signed-off-by: Stefan Berger <[email protected]>
>
> ---
> v3:
> - Applied Jarkko's tag

Already landed in Linus' tree 42 hours ago -- with Jarkko's tag:

https://git.kernel.org/linus/568c98a0f6ef