2024-05-22 17:59:52

by Dr. David Alan Gilbert

Subject: [PATCH] drm/xe: remove unused struct 'xe_gt_desc'

From: "Dr. David Alan Gilbert" <[email protected]>

'xe_gt_desc' is unused since
commit 1e6c20be6c83 ("drm/xe: Drop extra_gts[] declarations and
XE_GT_TYPE_REMOTE").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/gpu/drm/xe/xe_pci.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index f326dbb1cecd..2ca210480bd1 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -40,12 +40,6 @@ struct xe_subplatform_desc {
const u16 *pciidlist;
};

-struct xe_gt_desc {
- enum xe_gt_type type;
- u32 mmio_adj_limit;
- u32 mmio_adj_offset;
-};
-
struct xe_device_desc {
/* Should only ever be set for platforms without GMD_ID */
const struct xe_graphics_desc *graphics;
--
2.45.1

2024-05-23 17:36:04

by Rodrigo Vivi

Subject: Re: [PATCH] drm/xe: remove unused struct 'xe_gt_desc'

On Wed, May 22, 2024 at 06:58:40PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'xe_gt_desc' is unused since
> commit 1e6c20be6c83 ("drm/xe: Drop extra_gts[] declarations and
> XE_GT_TYPE_REMOTE").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Reviewed-by: Rodrigo Vivi <[email protected]>

and applying it right now...
thanks for the patch

> ---
> drivers/gpu/drm/xe/xe_pci.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index f326dbb1cecd..2ca210480bd1 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -40,12 +40,6 @@ struct xe_subplatform_desc {
> const u16 *pciidlist;
> };
>
> -struct xe_gt_desc {
> - enum xe_gt_type type;
> - u32 mmio_adj_limit;
> - u32 mmio_adj_offset;
> -};
> -
> struct xe_device_desc {
> /* Should only ever be set for platforms without GMD_ID */
> const struct xe_graphics_desc *graphics;
> --
> 2.45.1
>