2024-05-05 00:15:57

by Dr. David Alan Gilbert

Subject: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

From: "Dr. David Alan Gilbert" <[email protected]>

Commit fb5d1d389c9e ("ubd: open the backing files in ubd_add")

removed the last use of ubd_mutex.
Remove it.

Build and kernel startup test only.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
arch/um/drivers/ubd_kern.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 63fc062add708..2b855240fbabf 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -106,7 +106,6 @@ static inline void ubd_set_bit(__u64 bit, unsigned char *data)
#define DRIVER_NAME "uml-blkdev"

static DEFINE_MUTEX(ubd_lock);
-static DEFINE_MUTEX(ubd_mutex); /* replaces BKL, might not be needed */

static int ubd_ioctl(struct block_device *bdev, blk_mode_t mode,
unsigned int cmd, unsigned long arg);
--
2.45.0

2024-05-06 07:07:32

by Christoph Hellwig

Subject: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2024-05-20 15:12:58

by Dr. David Alan Gilbert

Subject: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

* Christoph Hellwig ([email protected]) wrote:
> Looks good:
>
> Reviewed-by: Christoph Hellwig <[email protected]>

Thanks Christoph; any ideas who might take this?

Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/

2024-05-20 15:21:08

by Christoph Hellwig

Subject: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
> * Christoph Hellwig ([email protected]) wrote:
> > Looks good:
> >
> > Reviewed-by: Christoph Hellwig <[email protected]>
>
> Thanks Christoph; any ideas who might take this?

Probably Richard who is alredy on Cc.

2024-05-20 19:24:30

by Richard Weinberger

Subject: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

----- Ursprüngliche Mail -----
> Von: "hch" <[email protected]>
> An: "Dr. David Alan Gilbert" <[email protected]>
> CC: "hch" <[email protected]>, "richard" <[email protected]>, "linux-um" <[email protected]>, "linux-kernel"
> <[email protected]>
> Gesendet: Montag, 20. Mai 2024 17:20:49
> Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

> On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
>> * Christoph Hellwig ([email protected]) wrote:
>> > Looks good:
>> >
>> > Reviewed-by: Christoph Hellwig <[email protected]>
>>
>> Thanks Christoph; any ideas who might take this?
>
> Probably Richard who is alredy on Cc.

Yes, after the merge window.

Thanks,
//richard

2024-05-23 15:11:25

by Dr. David Alan Gilbert

Subject: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

* Richard Weinberger ([email protected]) wrote:
> ----- Urspr?ngliche Mail -----
> > Von: "hch" <[email protected]>
> > An: "Dr. David Alan Gilbert" <[email protected]>
> > CC: "hch" <[email protected]>, "richard" <[email protected]>, "linux-um" <[email protected]>, "linux-kernel"
> > <[email protected]>
> > Gesendet: Montag, 20. Mai 2024 17:20:49
> > Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'
>
> > On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:
> >> * Christoph Hellwig ([email protected]) wrote:
> >> > Looks good:
> >> >
> >> > Reviewed-by: Christoph Hellwig <[email protected]>
> >>
> >> Thanks Christoph; any ideas who might take this?
> >
> > Probably Richard who is alredy on Cc.
>
> Yes, after the merge window.

Thanks; no rush, just trying to keep an eye on where each patch is
going.

Dave

> Thanks,
> //richard
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/