2024-05-20 12:56:13

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

From: "Dr. David Alan Gilbert" <[email protected]>

commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
has dropped all the users of the struct bridge_init from the
exynos_dp_core, while retaining unused structure definition.
Later on the driver was reworked and the definition migrated
to the analogix_dp driver. Remove unused struct bridge_init definition.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index df9370e0ff23..1e03f3525a92 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -36,11 +36,6 @@

static const bool verify_fast_training;

-struct bridge_init {
- struct i2c_client *client;
- struct device_node *node;
-};
-
static int analogix_dp_init_dp(struct analogix_dp_device *dp)
{
int ret;
--
2.45.1



2024-05-20 21:20:26

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

On Mon, May 20, 2024 at 01:55:51PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> has dropped all the users of the struct bridge_init from the
> exynos_dp_core, while retaining unused structure definition.
> Later on the driver was reworked and the definition migrated
> to the analogix_dp driver. Remove unused struct bridge_init definition.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-05-20 21:47:12

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

* Dmitry Baryshkov ([email protected]) wrote:
> On Mon, May 20, 2024 at 01:55:51PM +0100, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > has dropped all the users of the struct bridge_init from the
> > exynos_dp_core, while retaining unused structure definition.
> > Later on the driver was reworked and the definition migrated
> > to the analogix_dp driver. Remove unused struct bridge_init definition.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>

Thanks.

Dave

>
> --
> With best wishes
> Dmitry
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/