On Fri, May 31, 2024 at 11:20:54AM +1200, Chris Packham wrote:
> Like we do for charlcd, allow the configuration of the initial message
> on line-display devices.
Pushed to my review and testing queue, thanks!
I tweaked the define to be LINEDISP as Geert suggested.
--
With Best Regards,
Andy Shevchenko
On 1/06/24 03:35, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 11:20:54AM +1200, Chris Packham wrote:
>> Like we do for charlcd, allow the configuration of the initial message
>> on line-display devices.
> Pushed to my review and testing queue, thanks!
>
> I tweaked the define to be LINEDISP as Geert suggested.
Thanks a lot. Enjoy your well earned vacation.
On 1/06/24 03:35, Andy Shevchenko wrote:
> On Fri, May 31, 2024 at 11:20:54AM +1200, Chris Packham wrote:
>> Like we do for charlcd, allow the configuration of the initial message
>> on line-display devices.
> Pushed to my review and testing queue, thanks!
>
> I tweaked the define to be LINEDISP as Geert suggested.
>
Actually did you? I just checked what's in
andy/linux-auxdisplay/review-andy and it still uses LINE_DISP.
On Tue, Jun 4, 2024 at 12:59 AM Chris Packham
<[email protected]> wrote:
>
>
> On 1/06/24 03:35, Andy Shevchenko wrote:
> > On Fri, May 31, 2024 at 11:20:54AM +1200, Chris Packham wrote:
> >> Like we do for charlcd, allow the configuration of the initial message
> >> on line-display devices.
> > Pushed to my review and testing queue, thanks!
> >
> > I tweaked the define to be LINEDISP as Geert suggested.
> >
> Actually did you? I just checked what's in
> andy/linux-auxdisplay/review-andy and it still uses LINE_DISP.
Oh, it seems I forgot to squash the change, thank you for the catch!
--
With Best Regards,
Andy Shevchenko
On Tue, Jun 4, 2024 at 10:27 AM Andy Shevchenko
<[email protected]> wrote:
> On Tue, Jun 4, 2024 at 12:59 AM Chris Packham
> <[email protected]> wrote:
> > On 1/06/24 03:35, Andy Shevchenko wrote:
> > > On Fri, May 31, 2024 at 11:20:54AM +1200, Chris Packham wrote:
> > >> Like we do for charlcd, allow the configuration of the initial message
> > >> on line-display devices.
> > > Pushed to my review and testing queue, thanks!
> > >
> > > I tweaked the define to be LINEDISP as Geert suggested.
> > >
> > Actually did you? I just checked what's in
> > andy/linux-auxdisplay/review-andy and it still uses LINE_DISP.
>
> Oh, it seems I forgot to squash the change, thank you for the catch!
Now updated.
--
With Best Regards,
Andy Shevchenko