2024-06-02 14:56:49

by Abel Vesa

Subject: [PATCH] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default

The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP
does. So enabled it on QCP only.

Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 ++++
2 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
index a5662d39fdff..e34e70922cd3 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
@@ -522,6 +522,8 @@ smb2360_3: pmic@c {
#address-cells = <1>;
#size-cells = <0>;

+ status = "disabled";
+
smb2360_3_eusb2_repeater: phy@fd00 {
compatible = "qcom,smb2360-eusb2-repeater";
reg = <0xfd00>;
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 3de7565dda19..0db2f3ecad31 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -502,6 +502,10 @@ &remoteproc_cdsp {
status = "okay";
};

+&smb2360_3 {
+ status = "okay";
+};
+
&smb2360_0_eusb2_repeater {
vdd18-supply = <&vreg_l3d_1p8>;
vdd3-supply = <&vreg_l2b_3p0>;

---
base-commit: 0e1980c40b6edfa68b6acf926bab22448a6e40c9
change-id: 20240602-x1e80100-dts-pmics-drop-4th-smb2360-from-crd-501e8bb8bf95

Best regards,
--
Abel Vesa <[email protected]>

2024-06-02 16:20:46

by Johan Hovold

Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default

On Sun, Jun 02, 2024 at 05:56:24PM +0300, Abel Vesa wrote:
> The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP
> does. So enabled it on QCP only.
>
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Signed-off-by: Abel Vesa <[email protected]>

Gets rid of the nasty errors and WARNING on the CRD:

Reviewed-by: Johan Hovold <[email protected]>
Tested-by: Johan Hovold <[email protected]>

Johan

2024-06-02 22:37:06

by Dmitry Baryshkov

Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default

On Sun, Jun 02, 2024 at 05:56:24PM +0300, Abel Vesa wrote:
> The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP
> does. So enabled it on QCP only.

s/enabled/enable/

With that in place:

Reviewed-by: Dmitry Baryshkov <[email protected]>

foo-pmics.dtsi definitely is not the best solution, but it seems to be a
lesser evil.

>
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 4 ++++
> 2 files changed, 6 insertions(+)
>


--
With best wishes
Dmitry

2024-06-03 22:42:24

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Disable the SMB2360 4th instance by default

On 6/2/24 16:56, Abel Vesa wrote:
> The CRD board doesn't have the 4th SMB2360 PMIC populated while the QCP
> does. So enabled it on QCP only.
>
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Signed-off-by: Abel Vesa <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad