LinuxLists.cc - [PATCH] mfd: add missing MODULE

2024-06-10 02:21:59

Subject: [PATCH] mfd: add missing MODULE_DESCRIPTION() macros

On x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/arizona.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/pcf50633-gpio.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/timberdale.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/ssbi.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/rt4831.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/intel_soc_pmic_bxtwc.o

Add the missing invocation of the MODULE_DESCRIPTION() macro to all
files which have a MODULE_LICENSE().

This includes mfd-core.c and vexpress-sysreg.c which, although they
did not produce a warning with the x86 allmodconfig configuration, may
cause this warning with other configurations.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/mfd/arizona-core.c | 1 +
drivers/mfd/intel_soc_pmic_bxtwc.c | 1 +
drivers/mfd/mfd-core.c | 1 +
drivers/mfd/pcf50633-gpio.c | 1 +
drivers/mfd/rt4831.c | 1 +
drivers/mfd/ssbi.c | 1 +
drivers/mfd/timberdale.c | 1 +
drivers/mfd/vexpress-sysreg.c | 1 +
8 files changed, 8 insertions(+)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 19a0adf8ce3d..85ff8717d850 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -1429,4 +1429,5 @@ int arizona_dev_exit(struct arizona *arizona)
}
EXPORT_SYMBOL_GPL(arizona_dev_exit);

+MODULE_DESCRIPTION("Wolfson Arizona core driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
index 8dac0d41f64f..ba32cacfc499 100644
--- a/drivers/mfd/intel_soc_pmic_bxtwc.c
+++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
@@ -581,5 +581,6 @@ static struct platform_driver bxtwc_driver = {

module_platform_driver(bxtwc_driver);

+MODULE_DESCRIPTION("Intel Broxton Whiskey Cove PMIC MFD core driver");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Qipeng Zha <[email protected]>");
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 6ad5c93027af..b2742b1dce0c 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -437,5 +437,6 @@ int devm_mfd_add_devices(struct device *dev, int id,
}
EXPORT_SYMBOL(devm_mfd_add_devices);

+MODULE_DESCRIPTION("Core MFD support");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Ian Molton, Dmitry Baryshkov");
diff --git a/drivers/mfd/pcf50633-gpio.c b/drivers/mfd/pcf50633-gpio.c
index 4d2b53b12eeb..3e368219479a 100644
--- a/drivers/mfd/pcf50633-gpio.c
+++ b/drivers/mfd/pcf50633-gpio.c
@@ -88,4 +88,5 @@ int pcf50633_gpio_power_supply_set(struct pcf50633 *pcf,
}
EXPORT_SYMBOL_GPL(pcf50633_gpio_power_supply_set);

+MODULE_DESCRIPTION("NXP PCF50633 GPIO Driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/mfd/rt4831.c b/drivers/mfd/rt4831.c
index f8d6dc55b558..1ab8870e4ebf 100644
--- a/drivers/mfd/rt4831.c
+++ b/drivers/mfd/rt4831.c
@@ -115,4 +115,5 @@ static struct i2c_driver rt4831_driver = {
module_i2c_driver(rt4831_driver);

MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
+MODULE_DESCRIPTION("Richtek RT4831 core driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
index f849f2d34ec7..6e7aff6e2746 100644
--- a/drivers/mfd/ssbi.c
+++ b/drivers/mfd/ssbi.c
@@ -319,6 +319,7 @@ static struct platform_driver ssbi_driver = {
};
module_platform_driver(ssbi_driver);

+MODULE_DESCRIPTION("Qualcomm Single-wire Serial Bus Interface (SSBI) driver");
MODULE_LICENSE("GPL v2");
MODULE_VERSION("1.0");
MODULE_ALIAS("platform:ssbi");
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index a41e9a3e2064..333d5b874de3 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -853,4 +853,5 @@ module_pci_driver(timberdale_pci_driver);

MODULE_AUTHOR("Mocean Laboratories <[email protected]>");
MODULE_VERSION(DRV_VERSION);
+MODULE_DESCRIPTION("Timberdale FPGA MFD driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index eab82619ec31..d34d58ce46db 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -132,4 +132,5 @@ static struct platform_driver vexpress_sysreg_driver = {
};

module_platform_driver(vexpress_sysreg_driver);
+MODULE_DESCRIPTION("Versatile Express system registers driver");
MODULE_LICENSE("GPL v2");

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240609-md-drivers-mfd-ef0e92e2f8da

2024-06-10 11:41:22

by Liviu Dudau

[permalink] [raw]

Subject: Re: [PATCH] mfd: add missing MODULE_DESCRIPTION() macros

On Sun, Jun 09, 2024 at 07:21:28PM -0700, Jeff Johnson wrote:
> On x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/arizona.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/pcf50633-gpio.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/timberdale.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/ssbi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/rt4831.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/intel_soc_pmic_bxtwc.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
> files which have a MODULE_LICENSE().
>
> This includes mfd-core.c and vexpress-sysreg.c which, although they
> did not produce a warning with the x86 allmodconfig configuration, may
> cause this warning with other configurations.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/mfd/arizona-core.c | 1 +
> drivers/mfd/intel_soc_pmic_bxtwc.c | 1 +
> drivers/mfd/mfd-core.c | 1 +
> drivers/mfd/pcf50633-gpio.c | 1 +
> drivers/mfd/rt4831.c | 1 +
> drivers/mfd/ssbi.c | 1 +
> drivers/mfd/timberdale.c | 1 +
> drivers/mfd/vexpress-sysreg.c | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 19a0adf8ce3d..85ff8717d850 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1429,4 +1429,5 @@ int arizona_dev_exit(struct arizona *arizona)
> }
> EXPORT_SYMBOL_GPL(arizona_dev_exit);
>
> +MODULE_DESCRIPTION("Wolfson Arizona core driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
> index 8dac0d41f64f..ba32cacfc499 100644
> --- a/drivers/mfd/intel_soc_pmic_bxtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
> @@ -581,5 +581,6 @@ static struct platform_driver bxtwc_driver = {
>
> module_platform_driver(bxtwc_driver);
>
> +MODULE_DESCRIPTION("Intel Broxton Whiskey Cove PMIC MFD core driver");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Qipeng Zha <[email protected]>");
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 6ad5c93027af..b2742b1dce0c 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -437,5 +437,6 @@ int devm_mfd_add_devices(struct device *dev, int id,
> }
> EXPORT_SYMBOL(devm_mfd_add_devices);
>
> +MODULE_DESCRIPTION("Core MFD support");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Ian Molton, Dmitry Baryshkov");
> diff --git a/drivers/mfd/pcf50633-gpio.c b/drivers/mfd/pcf50633-gpio.c
> index 4d2b53b12eeb..3e368219479a 100644
> --- a/drivers/mfd/pcf50633-gpio.c
> +++ b/drivers/mfd/pcf50633-gpio.c
> @@ -88,4 +88,5 @@ int pcf50633_gpio_power_supply_set(struct pcf50633 *pcf,
> }
> EXPORT_SYMBOL_GPL(pcf50633_gpio_power_supply_set);
>
> +MODULE_DESCRIPTION("NXP PCF50633 GPIO Driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/mfd/rt4831.c b/drivers/mfd/rt4831.c
> index f8d6dc55b558..1ab8870e4ebf 100644
> --- a/drivers/mfd/rt4831.c
> +++ b/drivers/mfd/rt4831.c
> @@ -115,4 +115,5 @@ static struct i2c_driver rt4831_driver = {
> module_i2c_driver(rt4831_driver);
>
> MODULE_AUTHOR("ChiYuan Huang <[email protected]>");
> +MODULE_DESCRIPTION("Richtek RT4831 core driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index f849f2d34ec7..6e7aff6e2746 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -319,6 +319,7 @@ static struct platform_driver ssbi_driver = {
> };
> module_platform_driver(ssbi_driver);
>
> +MODULE_DESCRIPTION("Qualcomm Single-wire Serial Bus Interface (SSBI) driver");
> MODULE_LICENSE("GPL v2");
> MODULE_VERSION("1.0");
> MODULE_ALIAS("platform:ssbi");
> diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
> index a41e9a3e2064..333d5b874de3 100644
> --- a/drivers/mfd/timberdale.c
> +++ b/drivers/mfd/timberdale.c
> @@ -853,4 +853,5 @@ module_pci_driver(timberdale_pci_driver);
>
> MODULE_AUTHOR("Mocean Laboratories <[email protected]>");
> MODULE_VERSION(DRV_VERSION);
> +MODULE_DESCRIPTION("Timberdale FPGA MFD driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
> index eab82619ec31..d34d58ce46db 100644
> --- a/drivers/mfd/vexpress-sysreg.c
> +++ b/drivers/mfd/vexpress-sysreg.c
> @@ -132,4 +132,5 @@ static struct platform_driver vexpress_sysreg_driver = {
> };
>
> module_platform_driver(vexpress_sysreg_driver);
> +MODULE_DESCRIPTION("Versatile Express system registers driver");
> MODULE_LICENSE("GPL v2");

For the vexpress-sysreg.c:

Acked-by: Liviu Dudau <[email protected]>

Best regards,
Liviu

>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240609-md-drivers-mfd-ef0e92e2f8da
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

2024-06-10 12:11:43

by Andy Shevchenko

[permalink] [raw]

Subject: Re: [PATCH] mfd: add missing MODULE_DESCRIPTION() macros

On Mon, Jun 10, 2024 at 5:21 AM Jeff Johnson <[email protected]> wrote:
>
> On x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/arizona.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/pcf50633-gpio.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/timberdale.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/ssbi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/rt4831.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/intel_soc_pmic_bxtwc.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
> files which have a MODULE_LICENSE().
>
> This includes mfd-core.c and vexpress-sysreg.c which, although they
> did not produce a warning with the x86 allmodconfig configuration, may
> cause this warning with other configurations.

Acked-by: Andy Shevchenko <[email protected]> # for Intel Broxton PMIC

--
With Best Regards,
Andy Shevchenko

2024-06-10 12:56:01

by Charles Keepax

[permalink] [raw]

Subject: Re: [PATCH] mfd: add missing MODULE_DESCRIPTION() macros

2024-06-13 16:56:42

by Lee Jones

[permalink] [raw]

Subject: Re: (subset) [PATCH] mfd: add missing MODULE_DESCRIPTION() macros

On Sun, 09 Jun 2024 19:21:28 -0700, Jeff Johnson wrote:
> On x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/arizona.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/pcf50633-gpio.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/timberdale.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/ssbi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/rt4831.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mfd/intel_soc_pmic_bxtwc.o
>
> [...]

Applied, thanks!

[1/1] mfd: add missing MODULE_DESCRIPTION() macros
commit: b3e691c26f55731fd937c4b7ccbc150e10aa30a3

--
Lee Jones [李琼斯]