2024-06-14 15:41:12

by André Almeida

Subject: [PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

This driver can perfom async flips on primary planes, so enable it.

Signed-off-by: André Almeida <[email protected]>
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 0279c8aabdd1..0142beef20dc 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -931,6 +931,9 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe)

intel_plane_helper_add(plane);

+ if (plane->async_flip)
+ plane->base.async_flip = true;
+
return plane;

fail:
--
2.45.2

2024-06-14 19:28:16

by Rodrigo Vivi

Subject: Re: [PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

On Fri, Jun 14, 2024 at 12:35:32PM -0300, Andr? Almeida wrote:
> This driver can perfom async flips on primary planes, so enable it.
>

Cc: Ville Syrj?l? <[email protected]>
Cc: Naveen Kumar <[email protected]>
c: Vandita Kulkarni <[email protected]>

> Signed-off-by: Andr? Almeida <[email protected]>
> ---
> drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
> index 0279c8aabdd1..0142beef20dc 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_plane.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
> @@ -931,6 +931,9 @@ intel_primary_plane_create(struct drm_i915_private *dev_priv, enum pipe pipe)
>
> intel_plane_helper_add(plane);
>
> + if (plane->async_flip)
> + plane->base.async_flip = true;

I believe this is not enough and besides this we would also need to have
in the:
skl_universal_plane_create[2447] plane->async_flip = skl_plane_async_flip;

at: drivers/gpu/drm/i915/display/skl_universal_plane.c

> +
> return plane;
>
> fail:
> --
> 2.45.2
>