2024-01-23 08:39:20

by Krzysztof Kozlowski

Subject: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers

Regular expression used to match the unit address part should not allow
non-hex numbers.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
index f54e553e6c0e..71896cb10692 100644
--- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
@@ -145,7 +145,7 @@ patternProperties:
"^emc-table@[0-9]+$":
$ref: "#/$defs/emc-table"

- "^emc-tables@[a-z0-9-]+$":
+ "^emc-tables@[a-f0-9-]+$":
type: object
properties:
reg:
--
2.34.1

2024-01-23 09:21:48

by Jon Hunter

Subject: Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers

On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> index f54e553e6c0e..71896cb10692 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> @@ -145,7 +145,7 @@ patternProperties:
> "^emc-table@[0-9]+$":
> $ref: "#/$defs/emc-table"
>
> - "^emc-tables@[a-z0-9-]+$":
> + "^emc-tables@[a-f0-9-]+$":
> type: object
> properties:
> reg:


Thanks! We could add the fixes tag ...

Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema

Otherwise ...

Reviewed-by: Jon Hunter <[email protected]>

Jon

--
nvpublic

2024-01-23 09:50:30

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers

On 23/01/2024 10:20, Jon Hunter wrote:
>
> On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
>> Regular expression used to match the unit address part should not allow
>> non-hex numbers.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> .../bindings/memory-controllers/nvidia,tegra20-emc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> index f54e553e6c0e..71896cb10692 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> @@ -145,7 +145,7 @@ patternProperties:
>> "^emc-table@[0-9]+$":
>> $ref: "#/$defs/emc-table"
>>
>> - "^emc-tables@[a-z0-9-]+$":
>> + "^emc-tables@[a-f0-9-]+$":
>> type: object
>> properties:
>> reg:
>
>
> Thanks! We could add the fixes tag ...
>
> Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema

There is no bug here, really. At least no bug with impact, because dtc
won't allow DTS with non-hex numbers.

Best regards,
Krzysztof

2024-01-25 11:12:30

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers

On Tue, 23 Jan 2024 09:35:17 +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
>
>

Applied, thanks!

[1/1] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers
https://git.kernel.org/krzk/linux-mem-ctrl/c/2f542c937c48c2bd5a8ddf180b417fbe7152559f

Best regards,
--
Krzysztof Kozlowski <[email protected]>