2021-01-14 01:50:31

by Sean Christopherson

Subject: [PATCH v2 09/14] KVM: SVM: Unconditionally invoke sev_hardware_teardown()

Remove the redundant svm_sev_enabled() check when calling
sev_hardware_teardown(), the teardown helper itself does the check.
Removing the check from svm.c will eventually allow dropping
svm_sev_enabled() entirely.

No functional change intended.

Signed-off-by: Sean Christopherson <[email protected]>
---
arch/x86/kvm/svm/svm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index f89f702b2a58..bb7b99743bea 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -887,8 +887,7 @@ static void svm_hardware_teardown(void)
{
int cpu;

- if (svm_sev_enabled())
- sev_hardware_teardown();
+ sev_hardware_teardown();

for_each_possible_cpu(cpu)
svm_cpu_uninit(cpu);
--
2.30.0.284.gd98b1dd5eaa7-goog

2021-01-14 21:29:37

by Tom Lendacky

Subject: Re: [PATCH v2 09/14] KVM: SVM: Unconditionally invoke sev_hardware_teardown()

On 1/13/21 6:37 PM, Sean Christopherson wrote:
> Remove the redundant svm_sev_enabled() check when calling
> sev_hardware_teardown(), the teardown helper itself does the check.
> Removing the check from svm.c will eventually allow dropping
> svm_sev_enabled() entirely.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <[email protected]>

Reviewed-by: Tom Lendacky <[email protected]>

> ---
> arch/x86/kvm/svm/svm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index f89f702b2a58..bb7b99743bea 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -887,8 +887,7 @@ static void svm_hardware_teardown(void)
> {
> int cpu;
>
> - if (svm_sev_enabled())
> - sev_hardware_teardown();
> + sev_hardware_teardown();
>
> for_each_possible_cpu(cpu)
> svm_cpu_uninit(cpu);
>

2021-01-14 21:36:29

by Brijesh Singh

Subject: Re: [PATCH v2 09/14] KVM: SVM: Unconditionally invoke sev_hardware_teardown()

On 1/13/21 6:37 PM, Sean Christopherson wrote:
> Remove the redundant svm_sev_enabled() check when calling
> sev_hardware_teardown(), the teardown helper itself does the check.
> Removing the check from svm.c will eventually allow dropping
> svm_sev_enabled() entirely.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <[email protected]>
> ---
> arch/x86/kvm/svm/svm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)


Reviewed-by: Brijesh Singh <[email protected]>


>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index f89f702b2a58..bb7b99743bea 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -887,8 +887,7 @@ static void svm_hardware_teardown(void)
> {
> int cpu;
>
> - if (svm_sev_enabled())
> - sev_hardware_teardown();
> + sev_hardware_teardown();
>
> for_each_possible_cpu(cpu)
> svm_cpu_uninit(cpu);