2022-11-13 20:46:24

by Thomas Gleixner

[permalink] [raw]
Subject: [patch 03/10] scsi: lpfc: Remove linux/msi.h include

Nothing in this file needs anything from linux/msi.h

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: James Smart <[email protected]>
Cc: Dick Kennedy <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: [email protected]
---
drivers/scsi/lpfc/lpfc_init.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -36,7 +36,6 @@
#include <linux/firmware.h>
#include <linux/miscdevice.h>
#include <linux/percpu.h>
-#include <linux/msi.h>
#include <linux/irq.h>
#include <linux/bitops.h>
#include <linux/crash_dump.h>



2022-11-14 06:31:56

by James Smart

[permalink] [raw]
Subject: Re: [patch 03/10] scsi: lpfc: Remove linux/msi.h include

On 11/13/2022 12:33 PM, Thomas Gleixner wrote:
> Nothing in this file needs anything from linux/msi.h
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: James Smart <[email protected]>
> Cc: Dick Kennedy <[email protected]>
> Cc: "James E.J. Bottomley" <[email protected]>
> Cc: "Martin K. Petersen" <[email protected]>
> Cc: [email protected]
> ---
> drivers/scsi/lpfc/lpfc_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -36,7 +36,6 @@
> #include <linux/firmware.h>
> #include <linux/miscdevice.h>
> #include <linux/percpu.h>
> -#include <linux/msi.h>
> #include <linux/irq.h>
> #include <linux/bitops.h>
> #include <linux/crash_dump.h>
>

yep - agree.

Reviewed-by: James Smart <[email protected]>

-- james

2022-11-17 20:13:10

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [patch 03/10] scsi: lpfc: Remove linux/msi.h include


Thomas,

> Nothing in this file needs anything from linux/msi.h

Applied to 6.2/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering