From: Bean Huo <[email protected]>
This patch is to fix the following sparse warnings in ufshpb_set_hpb_read_to_upiu():
sparse warnings: (new ones prefixed by >>)
drivers/scsi/ufs/ufshpb.c:335:27: sparse: sparse: cast from restricted __be64
drivers/scsi/ufs/ufshpb.c:335:25: sparse: expected restricted __be64 [usertype] ppn_tmp
drivers/scsi/ufs/ufshpb.c:335:25: sparse: got unsigned long long [usertype]
Signed-off-by: Bean Huo <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/scsi/ufs/ufshpb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index a86d0cc50de2..5c8bb6dcc559 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -331,7 +331,7 @@ ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
cdb[0] = UFSHPB_READ;
if (hba->dev_quirks & UFS_DEVICE_QUIRK_SWAP_L2P_ENTRY_FOR_HPB_READ)
- ppn_tmp = swab64(ppn);
+ ppn_tmp = (__force __be64)swab64((__force u64)ppn);
/* ppn value is stored as big-endian in the host memory */
memcpy(&cdb[6], &ppn_tmp, sizeof(__be64));
--
2.25.1
On 11/11/21 14:24, Bean Huo wrote:
> - ppn_tmp = swab64(ppn);
> + ppn_tmp = (__force __be64)swab64((__force u64)ppn);
Reviewed-by: Bart Van Assche <[email protected]>
On Thu, 11 Nov 2021 23:24:52 +0100, Bean Huo wrote:
> From: Bean Huo <[email protected]>
>
> This patch is to fix the following sparse warnings in ufshpb_set_hpb_read_to_upiu():
>
> sparse warnings: (new ones prefixed by >>)
> drivers/scsi/ufs/ufshpb.c:335:27: sparse: sparse: cast from restricted __be64
> drivers/scsi/ufs/ufshpb.c:335:25: sparse: expected restricted __be64 [usertype] ppn_tmp
> drivers/scsi/ufs/ufshpb.c:335:25: sparse: got unsigned long long [usertype]
>
> [...]
Applied to 5.16/scsi-fixes, thanks!
[1/1] scsi: ufs: ufshpb: Fix sparse warning in ufshpb_set_hpb_read_to_upiu()
https://git.kernel.org/mkp/scsi/c/73185a13773a
--
Martin K. Petersen Oracle Linux Engineering