2020-01-21 10:24:10

by Yannick FERTRE

Subject: [PATCH] media: platform: stm32: don't print an error on probe deferral

From: Etienne Carriere <[email protected]>

Change stm32-cec driver to not print an error message when the
device probe operation is deferred.

Signed-off-by: Etienne Carriere <[email protected]>
---
drivers/media/platform/stm32/stm32-cec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
index 8a86b2c..9c137f1 100644
--- a/drivers/media/platform/stm32/stm32-cec.c
+++ b/drivers/media/platform/stm32/stm32-cec.c
@@ -291,7 +291,9 @@ static int stm32_cec_probe(struct platform_device *pdev)

cec->clk_cec = devm_clk_get(&pdev->dev, "cec");
if (IS_ERR(cec->clk_cec)) {
- dev_err(&pdev->dev, "Cannot get cec clock\n");
+ if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Cannot get cec clock\n");
+
return PTR_ERR(cec->clk_cec);
}

--
2.7.4

2020-01-23 09:54:43

by Philippe Cornu

Subject: Re: [PATCH] media: platform: stm32: don't print an error on probe deferral

Dears Yannick & Etienne,
Thank you for your patch,

Reviewed-by: Philippe Cornu <[email protected]>

Philippe :-)

On 1/21/20 11:22 AM, Yannick Fertre wrote:
> From: Etienne Carriere <[email protected]>
>
> Change stm32-cec driver to not print an error message when the
> device probe operation is deferred.
>
> Signed-off-by: Etienne Carriere <[email protected]>
> ---
> drivers/media/platform/stm32/stm32-cec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
> index 8a86b2c..9c137f1 100644
> --- a/drivers/media/platform/stm32/stm32-cec.c
> +++ b/drivers/media/platform/stm32/stm32-cec.c
> @@ -291,7 +291,9 @@ static int stm32_cec_probe(struct platform_device *pdev)
>
> cec->clk_cec = devm_clk_get(&pdev->dev, "cec");
> if (IS_ERR(cec->clk_cec)) {
> - dev_err(&pdev->dev, "Cannot get cec clock\n");
> + if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Cannot get cec clock\n");
> +
> return PTR_ERR(cec->clk_cec);
> }
>
>