2021-04-29 05:42:42

by Rajendra Nayak

Subject: [PATCH 2/2] arm64: dts: qcom: sc7280: Add "google,senor" to the compatible

The sc7280 IDP board is also called senor in the Chrome OS builds.
Add the "google,senor" compatible so coreboot/depthcharge knows what
device tree blob to pick

Signed-off-by: Rajendra Nayak <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 54d2cb3..a79fb5a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -11,7 +11,7 @@

/ {
model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
- compatible = "qcom,sc7280-idp", "qcom,sc7280";
+ compatible = "qcom,sc7280-idp", "google,senor", "qcom,sc7280";

aliases {
serial0 = &uart5;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-04-29 12:47:23

by Matthias Kaehlcke

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add "google,senor" to the compatible

On Thu, Apr 29, 2021 at 11:10:27AM +0530, Rajendra Nayak wrote:
> The sc7280 IDP board is also called senor in the Chrome OS builds.
> Add the "google,senor" compatible so coreboot/depthcharge knows what
> device tree blob to pick
>
> Signed-off-by: Rajendra Nayak <[email protected]>

Reviewed-by: Matthias Kaehlcke <[email protected]>

2021-04-29 13:41:10

by Doug Anderson

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add "google,senor" to the compatible

Hi,

On Wed, Apr 28, 2021 at 10:40 PM Rajendra Nayak <[email protected]> wrote:
>
> The sc7280 IDP board is also called senor in the Chrome OS builds.
> Add the "google,senor" compatible so coreboot/depthcharge knows what
> device tree blob to pick
>
> Signed-off-by: Rajendra Nayak <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <[email protected]>

2021-04-29 14:10:45

by Robert P. J. Day

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add "google,senor" to the compatible

On Thu, 29 Apr 2021, Doug Anderson wrote:

> Hi,
>
> On Wed, Apr 28, 2021 at 10:40 PM Rajendra Nayak <[email protected]> wrote:
> >
> > The sc7280 IDP board is also called senor in the Chrome OS builds.
> > Add the "google,senor" compatible so coreboot/depthcharge knows what
> > device tree blob to pick
> >
> > Signed-off-by: Rajendra Nayak <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Douglas Anderson <[email protected]>

subject line contains "google,senor"

rday

2021-04-30 04:22:02

by Rajendra Nayak

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add "google,senor" to the compatible

On 4/29/2021 7:13 PM, Robert P. J. Day wrote:
> On Thu, 29 Apr 2021, Doug Anderson wrote:
>
>> Hi,
>>
>> On Wed, Apr 28, 2021 at 10:40 PM Rajendra Nayak <[email protected]> wrote:
>>>
>>> The sc7280 IDP board is also called senor in the Chrome OS builds.
>>> Add the "google,senor" compatible so coreboot/depthcharge knows what
>>> device tree blob to pick
>>>
>>> Signed-off-by: Rajendra Nayak <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Douglas Anderson <[email protected]>
>
> subject line contains "google,senor"

are you suggesting it should not?

>
> rday
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation