2022-09-06 12:23:21

by Krzysztof Kozlowski

Subject: [PATCH 02/12] arm64: dts: qcom: sdm845: align APR services node names with dtschema

DT schema expects APR services node names to be "service":

qcom/sdm630-sony-xperia-nile-voyager.dtb: remoteproc@15700000: glink-edge:apr:service@4: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 98d34b5e1df2..8e7b577f78c2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -767,13 +767,13 @@ apr {
#size-cells = <0>;
qcom,intents = <512 20>;

- apr-service@3 {
+ service@3 {
reg = <APR_SVC_ADSP_CORE>;
compatible = "qcom,q6core";
qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
};

- q6afe: apr-service@4 {
+ q6afe: service@4 {
compatible = "qcom,q6afe";
reg = <APR_SVC_AFE>;
qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
@@ -785,7 +785,7 @@ q6afedai: dais {
};
};

- q6asm: apr-service@7 {
+ q6asm: service@7 {
compatible = "qcom,q6asm";
reg = <APR_SVC_ASM>;
qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
@@ -798,7 +798,7 @@ q6asmdai: dais {
};
};

- q6adm: apr-service@8 {
+ q6adm: service@8 {
compatible = "qcom,q6adm";
reg = <APR_SVC_ADM>;
qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
--
2.34.1

2022-09-07 03:57:54

by Steev Klimaszewski

Subject: Re: [PATCH 02/12] arm64: dts: qcom: sdm845: align APR services node names with dtschema

On 9/6/22 7:16 AM, Krzysztof Kozlowski wrote:
> DT schema expects APR services node names to be "service":
>
> qcom/sdm630-sony-xperia-nile-voyager.dtb: remoteproc@15700000: glink-edge:apr:service@4: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 98d34b5e1df2..8e7b577f78c2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -767,13 +767,13 @@ apr {
> #size-cells = <0>;
> qcom,intents = <512 20>;
>
> - apr-service@3 {
> + service@3 {
> reg = <APR_SVC_ADSP_CORE>;
> compatible = "qcom,q6core";
> qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> };
>
> - q6afe: apr-service@4 {
> + q6afe: service@4 {
> compatible = "qcom,q6afe";
> reg = <APR_SVC_AFE>;
> qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> @@ -785,7 +785,7 @@ q6afedai: dais {
> };
> };
>
> - q6asm: apr-service@7 {
> + q6asm: service@7 {
> compatible = "qcom,q6asm";
> reg = <APR_SVC_ASM>;
> qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> @@ -798,7 +798,7 @@ q6asmdai: dais {
> };
> };
>
> - q6adm: apr-service@8 {
> + q6adm: service@8 {
> compatible = "qcom,q6adm";
> reg = <APR_SVC_ADM>;
> qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";


Tested on the Lenovo Yoga C630

Tested-by: Steev Klimaszewski <[email protected]>