2023-12-12 03:38:54

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 5.15 000/141] 5.15.143-rc1 review

Hello!

On 11/12/23 12:20 p. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.143 release.
> There are 141 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.143-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

We're seeing new warnings with GCC-8 and failures with GCC-12 on x86/i386:

-----8<-----
In file included from /builds/linux/drivers/gpu/drm/i915/gem/i915_gem_context.c:2291:
/builds/linux/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c: In function '__igt_ctx_sseu':
/builds/linux/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:1284:9: error: left shift of negative value [-Werror=shift-negative-value]
~(~0 << (hweight32(engine->sseu.subslice_mask) / 2));
^~
cc1: all warnings being treated as errors
make[5]: *** [/builds/linux/scripts/Makefile.build:289: drivers/gpu/drm/i915/gem/i915_gem_context.o] Error 1
/builds/linux/drivers/gpu/drm/i915/i915_perf.c: In function 'get_default_sseu_config':
/builds/linux/drivers/gpu/drm/i915/i915_perf.c:2817:9: error: left shift of negative value [-Werror=shift-negative-value]
~(~0 << (hweight8(out_sseu->subslice_mask) / 2));
^~
cc1: all warnings being treated as errors
make[5]: *** [/builds/linux/scripts/Makefile.build:289: drivers/gpu/drm/i915/i915_perf.o] Error 1
----->8-----

Bisection points to:

commit 09ebdc1b3dfacc275d5eec3f1dcf632f18bbf5a8
Author: Arnd Bergmann <[email protected]>
Date: Tue Mar 8 22:56:14 2022 +0100

Kbuild: move to -std=gnu11

[ Upstream commit e8c07082a810fbb9db303a2b66b66b8d7e588b53 ]


For GCC-12 it's allmodconfig failing, for GCC-8 it's defconfig (i386_defconfig, x86_64_defconfig) just reporting new warnings.

Some reproducers:

tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig x86_64_defconfig

tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-12 --kconfig allmodconfig


Reported-by: Linux Kernel Functional Testing <[email protected]>

Greetings!

Daniel Díaz
[email protected]


2023-12-12 11:55:43

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 5.15 000/141] 5.15.143-rc1 review

On Mon, Dec 11, 2023 at 09:38:39PM -0600, Daniel D?az wrote:
> Hello!
>
> On 11/12/23 12:20 p.?m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.143 release.
> > There are 141 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.143-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> We're seeing new warnings with GCC-8 and failures with GCC-12 on x86/i386:
>
> -----8<-----
> In file included from /builds/linux/drivers/gpu/drm/i915/gem/i915_gem_context.c:2291:
> /builds/linux/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c: In function '__igt_ctx_sseu':
> /builds/linux/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:1284:9: error: left shift of negative value [-Werror=shift-negative-value]
> ~(~0 << (hweight32(engine->sseu.subslice_mask) / 2));
> ^~
> cc1: all warnings being treated as errors
> make[5]: *** [/builds/linux/scripts/Makefile.build:289: drivers/gpu/drm/i915/gem/i915_gem_context.o] Error 1
> /builds/linux/drivers/gpu/drm/i915/i915_perf.c: In function 'get_default_sseu_config':
> /builds/linux/drivers/gpu/drm/i915/i915_perf.c:2817:9: error: left shift of negative value [-Werror=shift-negative-value]
> ~(~0 << (hweight8(out_sseu->subslice_mask) / 2));
> ^~
> cc1: all warnings being treated as errors
> make[5]: *** [/builds/linux/scripts/Makefile.build:289: drivers/gpu/drm/i915/i915_perf.o] Error 1
> ----->8-----
>
> Bisection points to:
>
> commit 09ebdc1b3dfacc275d5eec3f1dcf632f18bbf5a8
> Author: Arnd Bergmann <[email protected]>
> Date: Tue Mar 8 22:56:14 2022 +0100
>
> Kbuild: move to -std=gnu11
> [ Upstream commit e8c07082a810fbb9db303a2b66b66b8d7e588b53 ]
>
>
> For GCC-12 it's allmodconfig failing, for GCC-8 it's defconfig (i386_defconfig, x86_64_defconfig) just reporting new warnings.
>
> Some reproducers:
>
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig x86_64_defconfig
>
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-12 --kconfig allmodconfig
>
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>

Ok, let me go drop this change and fix up the original commit that
required this language change to happen as we aren't quite ready for it
yet...

thanks,

greg k-h