2018-12-13 16:45:43

by Jeffrey Hugo

Subject: [PATCH] clk: qcom: Drop unused 8998 clock

gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
expect it to be needed for clients. Lets remove it because messing with
the clock has been observed to cause Linux hangs when the qdss_clk is
initialized by rpmcc.

Signed-off-by: Jeffrey Hugo <[email protected]>
---
drivers/clk/qcom/gcc-msm8998.c | 14 --------------
1 file changed, 14 deletions(-)

diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
index f3c2ab4..4b75a09 100644
--- a/drivers/clk/qcom/gcc-msm8998.c
+++ b/drivers/clk/qcom/gcc-msm8998.c
@@ -2005,19 +2005,6 @@ enum {
},
};

-static struct clk_branch gcc_lpass_trig_clk = {
- .halt_reg = 0x4701c,
- .halt_check = BRANCH_HALT,
- .clkr = {
- .enable_reg = 0x4701c,
- .enable_mask = BIT(0),
- .hw.init = &(struct clk_init_data){
- .name = "gcc_lpass_trig_clk",
- .ops = &clk_branch2_ops,
- },
- },
-};
-
static struct clk_branch gcc_mmss_noc_cfg_ahb_clk = {
.halt_reg = 0x9004,
.halt_check = BRANCH_HALT,
@@ -2710,7 +2697,6 @@ enum {
[GCC_HMSS_AT_CLK] = &gcc_hmss_at_clk.clkr,
[GCC_HMSS_RBCPR_CLK] = &gcc_hmss_rbcpr_clk.clkr,
[GCC_HMSS_TRIG_CLK] = &gcc_hmss_trig_clk.clkr,
- [GCC_LPASS_TRIG_CLK] = &gcc_lpass_trig_clk.clkr,
[GCC_MMSS_NOC_CFG_AHB_CLK] = &gcc_mmss_noc_cfg_ahb_clk.clkr,
[GCC_MMSS_QM_AHB_CLK] = &gcc_mmss_qm_ahb_clk.clkr,
[GCC_MMSS_QM_CORE_CLK] = &gcc_mmss_qm_core_clk.clkr,
--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

2018-12-13 16:55:12

by Marc Gonzalez

Subject: Re: [PATCH] clk: qcom: Drop unused 8998 clock

On 13/12/2018 17:44, Jeffrey Hugo wrote:

> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> expect it to be needed for clients. Lets remove it because messing with

"Let's" ;-p

> the clock has been observed to cause Linux hangs when the qdss_clk is
> initialized by rpmcc.
>
> Signed-off-by: Jeffrey Hugo <[email protected]>
> ---
> drivers/clk/qcom/gcc-msm8998.c | 14 --------------
> 1 file changed, 14 deletions(-)

Reviewed-by: Marc Gonzalez <[email protected]>

Regards.

2018-12-13 19:38:50

by Stephen Boyd

Subject: Re: [PATCH] clk: qcom: Drop unused 8998 clock

Quoting Jeffrey Hugo (2018-12-13 08:44:14)
> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> expect it to be needed for clients. Lets remove it because messing with
> the clock has been observed to cause Linux hangs when the qdss_clk is
> initialized by rpmcc.
>
> Signed-off-by: Jeffrey Hugo <[email protected]>

Fixes tag?