2006-11-05 00:24:09

by Ulrich Drepper

[permalink] [raw]
Subject: [PATCH] conditionalize some x86-64 options

Shouldn't the X86_MCE{INTEL,AMD} option depend on the other
manufacturer's CPU not being explicitly selected?

Signed-off-by: Ulrich Drepper <[email protected]>


diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
index 010d226..f414fe2 100644
--- a/arch/x86_64/Kconfig
+++ b/arch/x86_64/Kconfig
@@ -470,7 +470,7 @@ config X86_MCE

config X86_MCE_INTEL
bool "Intel MCE features"
- depends on X86_MCE && X86_LOCAL_APIC
+ depends on X86_MCE && X86_LOCAL_APIC && !MK8
default y
help
Additional support for intel specific MCE features such as
@@ -478,7 +478,7 @@ config X86_MCE_INTEL

config X86_MCE_AMD
bool "AMD MCE features"
- depends on X86_MCE && X86_LOCAL_APIC
+ depends on X86_MCE && X86_LOCAL_APIC && !MPSC
default y
help
Additional support for AMD specific MCE features such as


2006-11-05 01:08:30

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] conditionalize some x86-64 options

On Sunday 05 November 2006 01:24, Ulrich Drepper wrote:
> Shouldn't the X86_MCE{INTEL,AMD} option depend on the other
> manufacturer's CPU not being explicitly selected?

No -- the CPU selection on x86-64 means "optimize for", but doesn't
mean don't run on other CPUs.

-Andi

2006-11-06 23:19:26

by Ulrich Drepper

[permalink] [raw]
Subject: Re: [PATCH] conditionalize some x86-64 options

On 11/4/06, Andi Kleen <[email protected]> wrote:
> No -- the CPU selection on x86-64 means "optimize for", but doesn't
> mean don't run on other CPUs.

Then please explain this:

config X86_HT
bool
depends on SMP && !MK8
default y

2006-11-06 23:50:36

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] conditionalize some x86-64 options

On Tuesday 07 November 2006 00:19, Ulrich Drepper wrote:
> On 11/4/06, Andi Kleen <[email protected]> wrote:
> > No -- the CPU selection on x86-64 means "optimize for", but doesn't
> > mean don't run on other CPUs.
>
> Then please explain this:
>
> config X86_HT
> bool
> depends on SMP && !MK8
> default y

HT scheduler is just an optimization -- not needed for any functionality.
Doesn't break anything when not there.

But I agree the && !MK8 is bogus and should be probably removed
(or perhaps moved into a default)

-Andi