2023-07-26 14:36:08

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][V2][next] accel/qaic: remove redundant pointer pexec

Pointer pexec is being assigned a value however it is never read. The
assignment is redundant and can be removed. Replace sizeof(*pexec)
with sizeof the type and remove the declaration of pointer pexec.

Signed-off-by: Colin Ian King <[email protected]>
---

V2: completely remove the declaration of pexec and replace sizeof(*pexec)
with size of the type.

---
drivers/accel/qaic/qaic_data.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
index e9a1cb779b30..a90b64b325b4 100644
--- a/drivers/accel/qaic/qaic_data.c
+++ b/drivers/accel/qaic/qaic_data.c
@@ -1292,7 +1292,6 @@ static void update_profiling_data(struct drm_file *file_priv,
static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv,
bool is_partial)
{
- struct qaic_partial_execute_entry *pexec;
struct qaic_execute *args = data;
struct qaic_execute_entry *exec;
struct dma_bridge_chan *dbc;
@@ -1312,7 +1311,7 @@ static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr

received_ts = ktime_get_ns();

- size = is_partial ? sizeof(*pexec) : sizeof(*exec);
+ size = is_partial ? sizeof(struct qaic_partial_execute_entry) : sizeof(*exec);
n = (unsigned long)size * args->hdr.count;
if (args->hdr.count == 0 || n / args->hdr.count != size)
return -EINVAL;
@@ -1320,7 +1319,6 @@ static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr
user_data = u64_to_user_ptr(args->data);

exec = kcalloc(args->hdr.count, size, GFP_KERNEL);
- pexec = (struct qaic_partial_execute_entry *)exec;
if (!exec)
return -ENOMEM;

--
2.39.2



Subject: Re: [PATCH][V2][next] accel/qaic: remove redundant pointer pexec



On 7/26/2023 7:36 PM, Colin Ian King wrote:
> Pointer pexec is being assigned a value however it is never read. The
> assignment is redundant and can be removed. Replace sizeof(*pexec)
> with sizeof the type and remove the declaration of pointer pexec.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Pranjal Ramajor Asha Kanojiya <[email protected]>


2023-08-02 16:57:35

by Jeffrey Hugo

[permalink] [raw]
Subject: Re: [PATCH][V2][next] accel/qaic: remove redundant pointer pexec

On 8/1/2023 8:05 AM, Pranjal Ramajor Asha Kanojiya wrote:
>
>
> On 7/26/2023 7:36 PM, Colin Ian King wrote:
>> Pointer pexec is being assigned a value however it is never read. The
>> assignment is redundant and can be removed. Replace sizeof(*pexec)
>> with sizeof the type and remove the declaration of pointer pexec.
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Pranjal Ramajor Asha Kanojiya <[email protected]>
>

Reviewed-by: Jeffrey Hugo <[email protected]>

Applied to drm-misc-next

Thanks!

-Jeff