2017-08-31 14:07:33

by Colin King

Subject: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

From: Colin Ian King <[email protected]>

priv is being assigned but is never used, so remove it.

Cleans up clang build warning:
"warning: Value stored to 'priv' is never read"

Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
index c8b573d28dcf..bf7455fdafcc 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
@@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
*/
void rmnet_vnd_setup(struct net_device *rmnet_dev)
{
- struct rmnet_priv *priv;
-
- priv = netdev_priv(rmnet_dev);
netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);

rmnet_dev->netdev_ops = &rmnet_vnd_ops;
--
2.14.1

2017-08-31 20:34:24

by Subash Abhinov Kasiviswanathan

Subject: Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

On 2017-08-31 08:07, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> priv is being assigned but is never used, so remove it.
>
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
>
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
> implementation")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index c8b573d28dcf..bf7455fdafcc 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
> */
> void rmnet_vnd_setup(struct net_device *rmnet_dev)
> {
> - struct rmnet_priv *priv;
> -
> - priv = netdev_priv(rmnet_dev);
> netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
>
> rmnet_dev->netdev_ops = &rmnet_vnd_ops;

Thanks for fixing this.

Acked-by: Subash Abhinov Kasiviswanathan <[email protected]>

2017-09-02 01:34:55

by David Miller

Subject: Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

From: Colin King <[email protected]>
Date: Thu, 31 Aug 2017 15:07:27 +0100

> From: Colin Ian King <[email protected]>
>
> priv is being assigned but is never used, so remove it.
>
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
>
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
> Signed-off-by: Colin Ian King <[email protected]>

Applied.