2024-04-14 11:51:28

by Sumadhura Kalyan

Subject: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.

Issue found by checkpatch

Signed-off-by: sumadhura kalyan <[email protected]>
---
v1 -> v2: Updated subject line as per standards

.../vc04_services/vchiq-mmal/mmal-vchiq.h | 29 +++++++------------
1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
index 09f030919d4e..98909fde978e 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h
@@ -42,8 +42,7 @@ struct vchiq_mmal_port_buffer {

struct vchiq_mmal_port;

-typedef void (*vchiq_mmal_buffer_cb)(
- struct vchiq_mmal_instance *instance,
+typedef void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance,
struct vchiq_mmal_port *port,
int status, struct mmal_buffer *buffer);

@@ -101,31 +100,25 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance);
/* Initialise a mmal component and its ports
*
*/
-int vchiq_mmal_component_init(
- struct vchiq_mmal_instance *instance,
- const char *name,
- struct vchiq_mmal_component **component_out);
+int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance,
+ const char *name, struct vchiq_mmal_component **component_out);

-int vchiq_mmal_component_finalise(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_finalise(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

-int vchiq_mmal_component_enable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

-int vchiq_mmal_component_disable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_component *component);
+int vchiq_mmal_component_disable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_component *component);

/* enable a mmal port
*
* enables a port and if a buffer callback provided enque buffer
* headers as appropriate for the port.
*/
-int vchiq_mmal_port_enable(
- struct vchiq_mmal_instance *instance,
- struct vchiq_mmal_port *port,
+int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance,
+ struct vchiq_mmal_port *port,
vchiq_mmal_buffer_cb buffer_cb);

/* disable a port
--
2.25.1

2024-04-14 12:01:30

by Dan Carpenter

Subject: Re: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.

The subject is too vague.

On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
^^^^^^^^^^^^^^^^^^^^^^^^^
What issue?

A better commit message would be:

==================
Subject: [PATCH v3] staging: vc04_services: re-align function parameters

Checkpatch complains that:

CHECK: Lines should not end with a '('
#45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45:
+typedef void (*vchiq_mmal_buffer_cb)(

Re-align the function parameters to make checkpatch happy.
================

>
> Signed-off-by: sumadhura kalyan <[email protected]>
^ ^
You should make these capital letters... It's supposed to look formal
like you're signing a legal document.

regards,
dan carpenter