2022-10-11 20:35:06

by Kees Cook

Subject: [PATCH 2/5] pstore/ram: Move pmsg init earlier

Since the ftrace area can vary in size based on CPU count, move pmsg
initialization earlier so it will have a stable location.

Suggested-by: Paramjit Oberoi <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Tony Luck <[email protected]>
Signed-off-by: Kees Cook <[email protected]>
---
fs/pstore/ram.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 348820a3ce88..2f18563c8141 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -785,6 +785,11 @@ static int ramoops_probe(struct platform_device *pdev)
if (err)
goto fail_init;

+ err = ramoops_init_prz("pmsg", dev, cxt, &cxt->mprz, &paddr,
+ cxt->pmsg_size, 0);
+ if (err)
+ goto fail_init;
+
cxt->max_ftrace_cnt = (cxt->flags & RAMOOPS_FLAG_FTRACE_PER_CPU)
? nr_cpu_ids
: 1;
@@ -796,11 +801,6 @@ static int ramoops_probe(struct platform_device *pdev)
if (err)
goto fail_init;

- err = ramoops_init_prz("pmsg", dev, cxt, &cxt->mprz, &paddr,
- cxt->pmsg_size, 0);
- if (err)
- goto fail_init;
-
cxt->pstore.data = cxt;
/*
* Prepare frontend flags based on which areas are initialized.
--
2.34.1

2022-10-12 20:06:06

by Guilherme G. Piccoli

Subject: Re: [PATCH 2/5] pstore/ram: Move pmsg init earlier

On 11/10/2022 17:01, Kees Cook wrote:
> Since the ftrace area can vary in size based on CPU count, move pmsg
> initialization earlier so it will have a stable location.
>
> Suggested-by: Paramjit Oberoi <[email protected]>
> Cc: Anton Vorontsov <[email protected]>
> Cc: Colin Cross <[email protected]>
> Cc: Tony Luck <[email protected]>
> Signed-off-by: Kees Cook <[email protected]>
> ---

Reviewed: Guilherme G. Piccoli <[email protected]>

Since I'm not using pmsg my tests are of limited scope here, so better
to consider I just reviewed the patch heh
Cheers,


Guilherme